[wasm] Update for stable #10546
Merged
[wasm] Update for stable #10546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
commented
May 9, 2024
|
Visit the preview URL for this PR (updated for commit 96f0943): https://flutter-docs-prod--pr10546-i10519-wasm-updates-7ajkt6f7.web.app |
kevmoo
requested review from
sfshaza2,
atsansone,
parlough,
domesticmouse and
MaryaBelanger
as code owners
|
CC @mit-mit |
sfshaza2
reviewed
May 9, 2024
There was a problem hiding this comment.
@kevmoo, I have some confusion here:
- You don't want this update going live before 5/14? Can it go live now?
- So Wasm is in 3.22 stable. But it's not behind a flag? (Just checking)
- Just to clarify. Wasm is in stable 3.22, but serving wasm locally is not officially supported. yet?
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
1 task
|
You don't want this update going live before 5/14? Can it go live now? This is tied to the stable release. We should batch it for next week. So Wasm is in 3.22 stable. But it's not behind a flag? (Just checking) Yep. Just to clarify. Wasm is in stable 3.22, but serving wasm locally is not officially supported. yet? Using |
|
@sfshaza2 – fixed all of the issues and replied to your questions. Anything else? |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10519