Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain necessary headers in Wasm discussion #10341

Closed
1 task
kevmoo opened this issue Mar 29, 2024 · 2 comments
Closed
1 task

Explain necessary headers in Wasm discussion #10341

kevmoo opened this issue Mar 29, 2024 · 2 comments
Assignees
@sfshaza2
Labels
dev.integration Relates to platform integration e1-hours Effort: < 8 hrs p2-medium Necessary but not urgent concern. Resolve when possible. target.web Target apps on the web platform

Comments

@kevmoo
Copy link
Contributor

kevmoo commented Mar 29, 2024

Page URL

https://docs.flutter.dev/platform-integration/web/wasm/

Page source

https://github.com/flutter/website/tree/main/src/platform-integration/web/wasm.md

Describe the problem

image

The headers are REALLY hard to read here. We also don't explain why they are needed or general ways to think about defining them outside of dhttp.

Expected fix

List both required headers and ideally point to docs explaining why they are needed.

Additional context

Maybe https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cross-Origin-Embedder-Policy ?

Need to talk to @eyebrowsoffire

I would like to fix this problem.

  • I will try and fix this problem on docs.flutter.dev.
@parlough parlough mentioned this issue Apr 1, 2024
Merged
@parlough parlough changed the title [PAGE ISSUE]: 'Support for WebAssembly (Wasm)' - give more details on "special headers" Explain necessary headers in Wasm discussion Apr 1, 2024
@parlough parlough added p2-medium Necessary but not urgent concern. Resolve when possible. e1-hours Effort: < 8 hrs dev.integration Relates to platform integration target.web Target apps on the web platform labels Apr 1, 2024
parlough added a commit that referenced this issue Apr 1, 2024
@parlough
Fix contrast of 'console' code block language (#10344)
8b692d7 
Reuses `terminal` highlighting for `console`, as I recently consolidated
them.

Fixes #10342
Fixes #10335
Contributes to legibility portion of
#10341
@sfshaza2 sfshaza2 self-assigned this Apr 4, 2024
atsansone pushed a commit to atsansone/website that referenced this issue Apr 5, 2024
@parlough @atsansone
Fix contrast of 'console' code block language (flutter#10344)
898608f 
Reuses `terminal` highlighting for `console`, as I recently consolidated
them.

Fixes flutter#10342
Fixes flutter#10335
Contributes to legibility portion of
flutter#10341
@MaryaBelanger
Copy link
Contributor

An explanation of the headers was added in #10546 in the new "Serve the output with an HTTP server" section.

Can we close this?

@kevmoo
Copy link
Contributor Author

kevmoo commented Jun 17, 2024

Yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfshaza2 sfshaza2

Labels
dev.integration Relates to platform integration e1-hours Effort: < 8 hrs p2-medium Necessary but not urgent concern. Resolve when possible. target.web Target apps on the web platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @atsansone @parlough @sfshaza2 @MaryaBelanger