Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wasm docs - Update the Modify index.html bits for latest beta #10356

Closed
1 task
kevmoo opened this issue Apr 3, 2024 · 3 comments
Closed
1 task

Wasm docs - Update the Modify index.html bits for latest beta #10356

kevmoo opened this issue Apr 3, 2024 · 3 comments
Assignees
@sfshaza2
Labels
dev.integration Relates to platform integration e0-minutes Effort: < 60 min p1-high Major but not urgent concern: Resolve in months. Update each month. target.web Target apps on the web platform

Comments

@kevmoo
Copy link
Contributor

kevmoo commented Apr 3, 2024

Page URL

https://docs.flutter.dev/platform-integration/web/wasm/

Page source

https://github.com/flutter/website/tree/main/src/platform-integration/web/wasm.md

Describe the problem

Replace the bootstrap logic with the latest bits!

Expected fix

Steal from https://github.com/flutter/website/pull/10256/files#diff-08bd7b888bfd0cced4adcfa76e89f8705eec92fe13d273b51232af7a2afa6dd9R17-R23

<html>
  <body>
    <script src="flutter_bootstrap.js" async></script>
  </body>
<html>

Additional context

No response

I would like to fix this problem.

  • I will try and fix this problem on docs.flutter.dev.
@kevmoo kevmoo added p1-high Major but not urgent concern: Resolve in months. Update each month. e0-minutes Effort: < 60 min dev.integration Relates to platform integration target.web Target apps on the web platform labels Apr 3, 2024
@kevmoo
Copy link
Contributor Author

kevmoo commented Apr 3, 2024

Right @eyebrowsoffire ?

@eyebrowsoffire
Copy link
Contributor

Yep this looks right. The bigger change I'd actually like to make is to have:

  • A separate page for the new bootstrapping logic, with a warning in the documentation that it only works on 3.22 or higher
  • Links back and forth between the pages for the old and new bootstrapping logic
  • Wasm page should link to the new bootstrapping logic page.

@parlough parlough changed the title [PAGE ISSUE]: 'Support for WebAssembly (Wasm)' - update the Modify index.html bits for latest beta Wasm docs - Update the Modify index.html bits for latest beta Apr 4, 2024
@sfshaza2 sfshaza2 self-assigned this Apr 4, 2024
@sfshaza2
Copy link
Contributor

Fixed by PR #10546.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfshaza2 sfshaza2

Labels
dev.integration Relates to platform integration e0-minutes Effort: < 60 min p1-high Major but not urgent concern: Resolve in months. Update each month. target.web Target apps on the web platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @atsansone @eyebrowsoffire @sfshaza2