configure the output from the ros node launch #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fcolas @esteve @LukePhairatt @bdholt1 FYI I added this commit |
efernandez
approved these changes
Aug 28, 2018
nodes/mtnode.py
Outdated
| @@ -57,6 +57,7 @@ def __init__(self): | |||
| baudrate = get_param('~baudrate', 0) | |||
| timeout = get_param('~timeout', 0.002) | |||
| initial_wait = get_param('~initial_wait', 0.1) | |||
| output_config = get_param('~output_config', '') | |||
There was a problem hiding this comment.
Any reason why you don't set the same default as in the launch file here? oq,ad,wd,mf
There was a problem hiding this comment.
no particular reason ... so I added them in, to stick to your original style of default params
|
Many thanks for this contribution. However, I won't accept it as this since I don't want to needlessly update the configuration. I assume that you're aware that the configuration is stored on the device and, unless you are switching configuration time, you need to do the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added one the missing configuration option in the ros-node launch. Removed tabs in that file.
feature
being able to decide what output the sensor should publish (for example, mag.field + lin.accel.)
before
python mtdevice.py --configure "ad,mg"roslaunch xsens_driver xsens_driver.launchafter
roslaunch xsens_driver xsens_driver.launch// the .launch file including that config