Update for use with Noetic and Python3 #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently converting our code base to Noetic and python3, and have in the process done so for this project as well. I'm under quite a bit of pressure, so I have not had the chance to test this outside of our specific setup, which is an MTi-100 reporting Acc, Gyro, Mag, and Temp.
I'm sorry I'm not able to follow this through a bit more, but I hope it can be a good starting point.
Since implicit relative imports don't work in python3, I have created a module folder with implementation files with a _ prepended. This is the convention we use to solve this issue, but it does have the disadvantage that the entire history is lost to git :/
Other than the completely standard changes, I changed the classes in mtdef to inherit from the Enum class instead of the manually implemented enum functionality, which didn't work under python3 (the getName function specifically).