Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RELEASED - Version 6.1.95 - Breaking Changes #5409

Closed
92 tasks done
mririgoyen opened this issue Aug 6, 2020 · 14 comments
Closed
92 tasks done

RELEASED - Version 6.1.95 - Breaking Changes #5409

mririgoyen opened this issue Aug 6, 2020 · 14 comments
Assignees
@Templarian @mririgoyen @MrGrigri @Simran-B @JamesCoyle @PeterShaggyNoble @GreenTurtwig
Labels
Breaking Change Issues is has a change that will break something in the next release.
Milestone
Released in 6.1.95

Comments

@mririgoyen
Copy link
Collaborator

mririgoyen commented Aug 6, 2020 •
edited
Loading

Version 6.1.95 was released on Monday, September 6th, 2021.

We are now at the halfway point between v5 and v6, so I felt that it would be appropriate to have a single resource tracking all upcoming breaking changes that will be introduced in our v6 release. This issue will be kept updated as we get closer and closer to release and then will act as a reference.

Icons Being Removed (41)

The follow icons have been deprecated and will be removed entirely:

Icons Being Renamed (51)

The following icons are being renamed:

FAQ

When will v6 be released?

Version 6.1.95 was released on Monday, September 6th, 2021.

What's up with your version numbers?

We do not follow semver. Our version number indicates how many icons are available in the icon pack. However, we do try to lump as many breaking changes as possible into major version releases (so every 1000 icons). We aim to add approximately 100 icons per minor version release. We sometimes make breaking changes in minor version releases, so it is always important to look at our changelog when updating.
@mririgoyen mririgoyen added the Breaking Change Issues is has a change that will break something in the next release. label Aug 6, 2020
@mririgoyen mririgoyen added this to the Next Major - 6.0.xx milestone Aug 6, 2020
@mririgoyen mririgoyen pinned this issue Aug 6, 2020
@Sjoerd82
Copy link

Sjoerd82 commented Aug 7, 2020

How does this impact people that use Material Design icons via frameworks, like Vuetify?

@Simran-B
Copy link
Collaborator

Simran-B commented Aug 7, 2020

@Sjoerd82 It's a breaking change. If you upgrade to v6 you will have to change the icon names in code, unless Vuetify provides a compatibility layer. That applies to renamed icons, for removed ones you can either pick another icons if there is a suitable one, or use a third-party icon set to fill the gap like http://simpleicons.com/ for brand icons.

@Simran-B
Copy link
Collaborator

Simran-B commented Aug 7, 2020

Should we rename the face-woman* icons to face-female* for consistency? They are the only ones with "woman" in them, and we have none with "man" (well, except pac-man...)

@mririgoyen
Copy link
Collaborator Author

Should we rename the face-woman* icons to face-female* for consistency? They are the only ones with "woman" in them, and we have none with "man" (well, except pac-man...)

Let's open up issues for proposed breaking changes and leave this for a summary or discussion about the changes as a whole.

@Templarian Templarian mentioned this issue Oct 19, 2020
Closed
@mririgoyen mririgoyen mentioned this issue Nov 26, 2020
Closed
@Simran-B
Copy link
Collaborator

Simran-B commented Jan 11, 2021 •
edited
Loading

google-photos should be removed. We don't have the latest design (see #5293) and it's a brand icon anyway. The pinwheel icons will remain.

bootstrap should also be removed. They updated their logo with v5 (currently in beta, also see #5238) and it's a brand icon.

@mririgoyen
Copy link
Collaborator Author

I've updated #5293 and marked google-photos as deprecated. We'll leave bootstrap alone for now because it is a developer tool and that falls in the realm of our accepted icons. Consider it grandfathered in.

@mririgoyen mririgoyen changed the title Preparing for v6 - Upcoming Breaking Changes COMING SOON - Version 6 - Upcoming Breaking Changes Jan 13, 2021
@Templarian Templarian mentioned this issue Jan 25, 2021
Closed
@Templarian Templarian mentioned this issue Feb 11, 2021
Closed
@Templarian Templarian mentioned this issue Feb 27, 2021
Closed
@Templarian
Copy link
Owner

I added a note to address finally dropping the other font files as suggested in this issue: Templarian/MaterialDesign-Webfont#59

Going to take it one step further and only bundle Woff2 after 6.0 This means anyone targeting IE11 will need to use an older version. Almost all large companies are dropping IE11 support in 2021 so this is a good time for us.

@ziofat ziofat mentioned this issue Mar 8, 2021
Closed
@digitalpoin

This comment has been minimized.

Sign in to view
@mririgoyen

This comment has been minimized.

Sign in to view
@digitalpoin

This comment has been minimized.

Sign in to view
@Templarian Templarian mentioned this issue Apr 25, 2021
Closed
@ziofat ziofat mentioned this issue Jun 19, 2021
Closed
@Templarian Templarian mentioned this issue Jul 7, 2021
Closed
This was referenced Jul 7, 2021
Closed
Closed
@zgover
Copy link

zgover commented Jul 30, 2021

@goyney would you mind editing the original issue content—providing brief insights of the icon task list under 'Icons Being Removed'—specify either name of alternative or aliased resolution or just icon EOL decision. This will enable support for substantially greater consumer awareness while migrating; saving time, resources and energy by minimizing page navigations to the respective icon issue.

@mririgoyen
Copy link
Collaborator Author

@goyney would you mind editing the original issue content—providing brief insights of the icon task list under 'Icons Being Removed'—specify either name of alternative or aliased resolution or just icon EOL decision. This will enable support for substantially greater consumer awareness while migrating; saving time, resources and energy by minimizing page navigations to the respective icon issue.

This issue serves as that reference. Each linked issue contains more information if absolutely needed. The TL;DR is that we are deprecated and removing most brand icons and pointing people to SimpleIcons for brand icon needs. Brand icons carry a certain amount of risk so we are slowly reducing that surface area.

@Templarian Templarian mentioned this issue Jul 30, 2021
Closed
@juhasev
Copy link

juhasev commented Aug 5, 2021

I think we should take it easy on renaming and deleting icons. This is a major burden to update hundreds of icons currently in use especially the ones that got deleted.

@mririgoyen
Copy link
Collaborator Author

mririgoyen commented Aug 24, 2021 •
edited
Loading

I think we should take it easy on renaming and deleting icons. This is a major burden to update hundreds of icons currently in use especially the ones that got deleted.

We do not make breaking changes lightly. However, when we do, we align them to the major breaking version change (in this case v5 ➜ v6). You are not required to update, but if you do, you will need to update any places in which you are affected by the changes. This is the case for nearly every piece of open-source software out there.

It's also important to note that we don't follow semver here. So, we literally amass breaking changes over the course of building up another 1000 new icons. This usually happens over the course of about 10 months, so when a major version comes, it's important we take our time.

Please use this issue as your migration path once v6 is released if you chose to upgrade.

@mririgoyen mririgoyen changed the title COMING SOON - Version 6 - Upcoming Breaking Changes RELEASING SOON - Version 6 - Upcoming Breaking Changes Aug 30, 2021
@ziofat ziofat mentioned this issue Sep 6, 2021
Closed
@mririgoyen mririgoyen changed the title RELEASING SOON - Version 6 - Upcoming Breaking Changes RELEASED - Version 6.1.95 - Breaking Changes Sep 7, 2021
@mririgoyen mririgoyen mentioned this issue Sep 8, 2021
Closed
This was referenced Sep 9, 2021
Closed
Closed
@mririgoyen mririgoyen unpinned this issue Sep 14, 2021
@Templarian Templarian mentioned this issue Sep 20, 2021
Closed
This was referenced Sep 29, 2021
Closed
Closed
@a-kriya a-kriya mentioned this issue Oct 12, 2021
Closed
@kumattau kumattau mentioned this issue Oct 19, 2021
Merged
This was referenced Oct 20, 2021
Closed
Merged
limitedmage pushed a commit to sourcegraph/sourcegraph-public-snapshot that referenced this issue Oct 26, 2021
update mdi-react, modify last sync icon (#26617)
6040bbc 
Updates `mdi-react` to latest version in order to fix #26016

- Last sync time icon has been changed to `weather-cloudy-clock` (fixes #26016)
  - before: 
![image](https://user-images.githubusercontent.com/206864/138783780-43da183a-770d-4a3b-8cbc-b26b516dd88f.png)
  - after: 
![image](https://user-images.githubusercontent.com/206864/138783790-66adc2f5-c851-4fa3-854c-7f808c51c7a4.png)

- Some icons have been renamed in the new version of MDI:
  - `user` -> `account`
  - `users` -> `account-multiple`
  - `do-not-disturb` -> `minus-circle`
  - `error` -> `alert-circle`
- The `amazon` icon has been [removed](Templarian/MaterialDesign#5409) from the latest MDI. I've replaced with the `aws` icon which should be fine for the one scenario we use it in (adding a repo from AWS Code Commit).
  - before: 
![image](https://user-images.githubusercontent.com/206864/138782276-22f51ed6-19c0-43b8-a91c-33b6bd7ac014.png)
  - after: 
![image](https://user-images.githubusercontent.com/206864/138782317-8f5a0740-ac6a-4bf5-b5f0-b79fcf505816.png)
- The `cancel` icon has been flipped in the latest MDI to match other icons with the same symbol and meaning (e.g. `account-cancel`)
  - before: 
![image](https://user-images.githubusercontent.com/206864/138782743-95295273-89d3-41fb-8ece-b78e9335434a.png)
  - after: 
![image](https://user-images.githubusercontent.com/206864/138782764-100fb24d-9755-41f0-b6dd-bc1bf170155e.png)
- The `book-open-variant` icon that we use for API docs has been changed to have text in it. I have changed it to `book-open-blank-variant` so it remains blank.
@taylorsilva taylorsilva mentioned this issue Jan 4, 2022
Closed
@pedrolamas pedrolamas mentioned this issue Feb 20, 2022
Merged
@SeaLife SeaLife mentioned this issue May 3, 2022
Open
@shabeeb-aot shabeeb-aot mentioned this issue May 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Templarian Templarian

@mririgoyen mririgoyen

@MrGrigri MrGrigri

@Simran-B Simran-B

@JamesCoyle JamesCoyle

@PeterShaggyNoble PeterShaggyNoble

@GreenTurtwig GreenTurtwig

Labels
Breaking Change Issues is has a change that will break something in the next release.
Projects
None yet
Milestone
Released in 6.1.95
Development

No branches or pull requests