Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

The last sync time icon is misleading #26016

Closed
rrhyne opened this issue Oct 13, 2021 · 9 comments · Fixed by #26617
Closed

The last sync time icon is misleading #26016

rrhyne opened this issue Oct 13, 2021 · 9 comments · Fixed by #26617
Assignees
@limitedmage
Labels
team/search-product Issues owned by the search product team

Comments

@rrhyne
Copy link
Contributor

rrhyne commented Oct 13, 2021

The last sync icon in search results is misleading. It used to denote repositories are currently being synced in the top navigation, which implies the search result is also being synced.

Replacing with mdi:weather-cloudy-clock will correct this issue:

image
@rrhyne rrhyne added the team/search-product Issues owned by the search product team label Oct 13, 2021
@camdencheek
Copy link
Member

Should be an easy swap...except that icon doesn't exist in mdi-react. I think the solution is just to ask mdi-react to update the version of the material design icons it uses? It seems to be quite a few versions behind

cc @limitedmage @novoselrok in case you have a better idea

@limitedmage
Copy link
Contributor

I've filed an issue with mdi-react: levrik/mdi-react#89

Looks like, officially, MDI recommends using @mdi/js with @mdi/react instead of mdi-react: https://dev.materialdesignicons.com/getting-started/react (FYI @sourcegraph/frontend-platform, maybe this is something we want to move to?)

@benvenker
Copy link
Contributor

Iceboxing until we hear back from mdi-react

@rrhyne
Copy link
Contributor Author

rrhyne commented Oct 14, 2021

The last release of this library was 2018. I think we need to change this ticket to moving to @mid/js as per @limitedmage's comment. cc @sourcegraph/frontend-platform

@levrik
Copy link

levrik commented Oct 18, 2021 •
edited
Loading

@rrhyne mdi-react is kept in sync with upstream (@mdi/svg) via Renovate. I've just got a PR for v6 of mdi which I've immediately merged. A new release of mdi-react is being created automatically now.

@rrhyne
Copy link
Contributor Author

rrhyne commented Oct 19, 2021

@levrik, I am guilty of looking only at the repo's past releases (which must have been handled a bit differently) and not your commits. Thanks, tons for updating!

@rrhyne
Copy link
Contributor Author

rrhyne commented Oct 19, 2021 •
edited
Loading

@limitedmage it looks like we are on 7.3 where the release levrik mentioned above is 8.0. Can we bump this library or is this FPT's realm?

@levrik
Copy link

levrik commented Oct 20, 2021

@rrhyne But I have to admit that there were several v6 releases of upstream starting ~1 month ago which I didn't get PRs for. Unsure why.

@limitedmage
Copy link
Contributor

limitedmage commented Oct 20, 2021 •
edited
Loading

@rrhyne I'll double-check that the breaking changes don't affect us and if so, will bump the library and change the sync icon.

@limitedmage limitedmage mentioned this issue Oct 25, 2021
Merged
limitedmage pushed a commit that referenced this issue Oct 26, 2021
update mdi-react, modify last sync icon (#26617)
6040bbc 
Updates `mdi-react` to latest version in order to fix #26016

- Last sync time icon has been changed to `weather-cloudy-clock` (fixes #26016)
  - before: 
![image](https://user-images.githubusercontent.com/206864/138783780-43da183a-770d-4a3b-8cbc-b26b516dd88f.png)
  - after: 
![image](https://user-images.githubusercontent.com/206864/138783790-66adc2f5-c851-4fa3-854c-7f808c51c7a4.png)

- Some icons have been renamed in the new version of MDI:
  - `user` -> `account`
  - `users` -> `account-multiple`
  - `do-not-disturb` -> `minus-circle`
  - `error` -> `alert-circle`
- The `amazon` icon has been [removed](Templarian/MaterialDesign#5409) from the latest MDI. I've replaced with the `aws` icon which should be fine for the one scenario we use it in (adding a repo from AWS Code Commit).
  - before: 
![image](https://user-images.githubusercontent.com/206864/138782276-22f51ed6-19c0-43b8-a91c-33b6bd7ac014.png)
  - after: 
![image](https://user-images.githubusercontent.com/206864/138782317-8f5a0740-ac6a-4bf5-b5f0-b79fcf505816.png)
- The `cancel` icon has been flipped in the latest MDI to match other icons with the same symbol and meaning (e.g. `account-cancel`)
  - before: 
![image](https://user-images.githubusercontent.com/206864/138782743-95295273-89d3-41fb-8ece-b78e9335434a.png)
  - after: 
![image](https://user-images.githubusercontent.com/206864/138782764-100fb24d-9755-41f0-b6dd-bc1bf170155e.png)
- The `book-open-variant` icon that we use for API docs has been changed to have text in it. I have changed it to `book-open-blank-variant` so it remains blank.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@limitedmage limitedmage

Labels
team/search-product Issues owned by the search product team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update mdi-react, modify last sync icon sourcegraph/sourcegraph-public-snapshot
5 participants
@limitedmage @rrhyne @benvenker @levrik @camdencheek