-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Update Material Design Icons to 5.9.55 and add support for new mayor version 6.x - 6.3.95 #174
Conversation
Hi @kumattau thank you for the work here! Regarding the breaking changes we will need to review them carefully since probably applications using What do you think @ccordoba12 ? |
Note: https://dev.materialdesignicons.com/upgrade to check the removed or renamed icons |
After talking with @ccordoba12 we think that the best approach could be to add another prefix for Material Design |
I can do updating Material Design Icon 5.x to the latest version and adding new The point I'm concerned about breaking changes is:
|
Thanks @kumattau ! And regarding the concerns:
We are currently bundling Material Desing
That's quite true. Maybe we should only keep at most two mayor versions for the font sets we support. So for example, if we add support for Font Awesome 6 (which is in now beta but in the future could be added here) we should drop Font Awesome 4.7 If you have more concerns or ideas let us know @kumattau ! |
I will work manually, so I think updating the automatic script need to be considered separately. I will create "PR: adding 6.3.95" and "PR: updating 5.3.55 to 5.9.55" except for updating UPDATE.md. |
Thanks @kumattau !! |
* Lisence is changed from SIL Open Font License to Apache License Version 2.0 * Re-add all old icon names (windows, json, markdown) for compatibility
ed4a36e
to
d53610a
Compare
… 6.x python fontname.py "Material Design Icons 5.9.55" materialdesignicons5-webfont.ttf https://github.com/chrissimpkins/fontname.py/blob/v2.0.0/fontname.py
Hi, @dalthviz
I finished the updates including UPDATE.md. I force pushed 3 commits to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kumattau! This is awesome 👍
This PR is for updating Material Design Icons to version 6.3.95.
Compared to previous bundled version 5.4.55,
I think this PR can be merged if the breaking changes are no problem.