Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update Material Design Icons to 5.9.55 and add support for new mayor version 6.x - 6.3.95 #174

Merged
merged 3 commits into from
Oct 20, 2021

Conversation

kumattau
Copy link
Contributor

@kumattau kumattau commented Oct 19, 2021

This PR is for updating Material Design Icons to version 6.3.95.

Compared to previous bundled version 5.4.55,

I think this PR can be merged if the breaking changes are no problem.

@dalthviz
Copy link
Member

Hi @kumattau thank you for the work here!

Regarding the breaking changes we will need to review them carefully since probably applications using QtAwesome could break as for example Spyder (which is something that happened before). So first, we need to plan better the introduction of font breaking changes which maybe should be reflected in the version of QtAwesome (then this should be included for a QtAwesome 2.0.0 release) or think if QtAwesome should help keeping some level of compatibility when doing the font updates.

What do you think @ccordoba12 ?

@dalthviz dalthviz added this to the future milestone Oct 19, 2021
@dalthviz
Copy link
Member

Note: https://dev.materialdesignicons.com/upgrade to check the removed or renamed icons

@dalthviz dalthviz modified the milestones: future, v1.1.0 Oct 19, 2021
@dalthviz
Copy link
Member

After talking with @ccordoba12 we think that the best approach could be to add another prefix for Material Design 6.x (something like mdi6) and instead update the current mdi prefix to use the latest 5.x Material Desing version (5.9.55). With that we think we can assure better compatibility. What do you think @kumattau ? Would you like to work on that ? Let us know !

@kumattau
Copy link
Contributor Author

kumattau commented Oct 19, 2021

I can do updating Material Design Icon 5.x to the latest version and adding new mdi6 Material Design Icon 6.x in a few day.

The point I'm concerned about breaking changes is:

@dalthviz
Copy link
Member

Thanks @kumattau ! And regarding the concerns:

a few icons are removed or renamed between minor versions. Is it acceptable ?
https://dev.materialdesignicons.com/upgrade#5.3.45-to-5.4.55

We are currently bundling Material Desing 5.4.55 so from what I checked the update will only include the rename of an icon (a change introduced from 5.4.45 to 5.5.55) which we will need to readd after generating the *-charmap.json. The other changes between version seems like only new icons but we will need to carefully check just in case (and even in the future maybe figure out a way to do those checks and corrections automatically as well as provide a way to fallback to a default icon or some other handling).

If each version is bundled with each update, the whl size will increase (Material Design Icon 6.x is 1MB over).

That's quite true. Maybe we should only keep at most two mayor versions for the font sets we support. So for example, if we add support for Font Awesome 6 (which is in now beta but in the future could be added here) we should drop Font Awesome 4.7

If you have more concerns or ideas let us know @kumattau !

@kumattau
Copy link
Contributor Author

we will need to readd after generating the *-charmap.json.

I will work manually, so I think updating the automatic script need to be considered separately.
https://github.com/spyder-ide/qtawesome/blob/master/UPDATE.md#material-design-icons

I will create "PR: adding 6.3.95" and "PR: updating 5.3.55 to 5.9.55" except for updating UPDATE.md.

@dalthviz
Copy link
Member

Thanks @kumattau !!

* Lisence is changed from SIL Open Font License to Apache License Version 2.0
* Re-add all old icon names (windows, json, markdown) for compatibility
@kumattau kumattau force-pushed the mdi-6.3.95 branch 2 times, most recently from ed4a36e to d53610a Compare October 20, 2021 13:36
@kumattau
Copy link
Contributor Author

Hi, @dalthviz

I will create "PR: adding 6.3.95" and "PR: updating 5.3.55 to 5.9.55" except for updating UPDATE.md.

I finished the updates including UPDATE.md. I force pushed 3 commits to this PR.

@dalthviz dalthviz changed the title PR: Update Material Design Icons to version 6.3.95 PR: Update Material Design Icons to 5.9.55 and add support for new mayor version 6.x - 6.3.95 Oct 20, 2021
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kumattau! This is awesome 👍

@dalthviz dalthviz merged commit 1ceafa1 into spyder-ide:master Oct 20, 2021
@kumattau kumattau deleted the mdi-6.3.95 branch October 20, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants