-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filings UI: replace SVG with MDI icon #11675
Comments
This is NOT tech debt, because we didn't know for sure whether MDI would support the new icon we needed, so the SVG version was a permanent solution... but not an ideal solution. Now the icon is available and that's better. |
@shabeeb-aot can your team work on this when completing the dissolution filing? |
any idea how much effort it is? @severinbeauvais |
Maybe 10 minutes of work + overhead for creating branch, committing, reviewing, etc -- this is a good candidate for doing as part of another ticket! |
@severinbeauvais - Does this impact all the icons across all our applications? Just trying to understand the impact. |
If no icons that we use are deprecated in the latest icon library (and I don't if so or not) then there should be zero impact. The icons we use are easy to search for in the code, so maybe we need another step above to ensure they are not deprecated/removed from the latest icon library version. |
Dependency and Relationships labels added. |
Some icons are missing in mdidesign - Breaking Changes |
Not required for now |
The Dissolve This Company button icon previously didn't not exist, so a SVG version was implemented.
Now, the Material Design Icons library includes this icon, so we should change over and clean up our code a bit.
Refs:
Templarian/MaterialDesign#6261
https://www.npmjs.com/package/@mdi/font/v/6.6.95
The text was updated successfully, but these errors were encountered: