Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filings UI: replace SVG with MDI icon #11675

Open
severinbeauvais opened this issue Mar 24, 2022 · 9 comments
Open

Filings UI: replace SVG with MDI icon #11675

severinbeauvais opened this issue Mar 24, 2022 · 9 comments
Labels
Dependency To highlight the dependency(intra team, external, third parties) Dev Tasks for developers ENTITY Business Team Pay Work for Pay Team

Comments

@severinbeauvais
Copy link
Collaborator

The Dissolve This Company button icon previously didn't not exist, so a SVG version was implemented.

Now, the Material Design Icons library includes this icon, so we should change over and clean up our code a bit.

image.png

Refs:
Templarian/MaterialDesign#6261
https://www.npmjs.com/package/@mdi/font/v/6.6.95

image.png

@severinbeauvais severinbeauvais added the ENTITY Business Team label Mar 24, 2022
@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Mar 24, 2022

This is NOT tech debt, because we didn't know for sure whether MDI would support the new icon we needed, so the SVG version was a permanent solution... but not an ideal solution. Now the icon is available and that's better.

@sienna-oldaccountdontuse
Copy link
Contributor

@shabeeb-aot can your team work on this when completing the dissolution filing?
FYI @jyoti3286 @SateeshFW

@sienna-oldaccountdontuse sienna-oldaccountdontuse added the Pay Work for Pay Team label Mar 25, 2022
@jyoti3286
Copy link
Contributor

any idea how much effort it is? @severinbeauvais
CC: @lmcclung

@severinbeauvais
Copy link
Collaborator Author

  1. update library import version
  2. update 1 line of code
  3. delete obsolete svg file

Maybe 10 minutes of work + overhead for creating branch, committing, reviewing, etc -- this is a good candidate for doing as part of another ticket!

@jyoti3286
Copy link
Contributor

@severinbeauvais - Does this impact all the icons across all our applications? Just trying to understand the impact.

@severinbeauvais
Copy link
Collaborator Author

If no icons that we use are deprecated in the latest icon library (and I don't if so or not) then there should be zero impact.

The icons we use are easy to search for in the code, so maybe we need another step above to ensure they are not deprecated/removed from the latest icon library version.

@sienna-oldaccountdontuse sienna-oldaccountdontuse added the Dependency To highlight the dependency(intra team, external, third parties) label Apr 14, 2022
@sienna-oldaccountdontuse
Copy link
Contributor

Dependency and Relationships labels added.
@SateeshFW @jyoti3286 please let us know if it makes sense for your team to do this work

@shabeeb-aot
Copy link
Contributor

Some icons are missing in "@mdi/font": "^6.6.96", version. like we pdf icon which we used inside view document.
So maybe we have to use pdf icon Screen Shot 2022-05-10 at 2.57.57 PM.png we have to use SVG for the pdf icon

mdidesign - Breaking Changes
Templarian/MaterialDesign#5409

After an update in local, it will be like this
Screen Shot 2022-05-10 at 3.04.53 PM.png

@SateeshFW SateeshFW added the Dev Tasks for developers label May 11, 2022
@jyoti3286
Copy link
Contributor

Not required for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependency To highlight the dependency(intra team, external, third parties) Dev Tasks for developers ENTITY Business Team Pay Work for Pay Team
Projects
None yet
Development

No branches or pull requests

5 participants