update mdi-react, modify last sync icon #26617
Conversation
| @@ -170,8 +170,8 @@ export const BatchSpecExecutionDetailsPage: React.FunctionComponent<BatchSpecExe | |||
| // execution.state === BatchSpecState.COMPLETED | |||
There was a problem hiding this comment.
@sourcegraph/batchers Is there a reason this code is commented out instead of deleted?
There was a problem hiding this comment.
It disappears in a PR that's already open
| import * as React from 'react' | ||
|
|
||
| import { LinkOrSpan } from '@sourcegraph/shared/src/components/LinkOrSpan' | ||
| import * as GQL from '@sourcegraph/shared/src/graphql/schema' | ||
|
|
||
| export const RegistryExtensionSourceBadge: React.FunctionComponent<{ | ||
| extension: Pick<GQL.IRegistryExtension, 'remoteURL' | 'registryName' | 'isLocal'> | ||
| showIcon?: boolean |
There was a problem hiding this comment.
This prop has been removed altogether because it is never used.
|
Notifying subscribers in CODENOTIFY files for diff b1ff8e2...d98d0d1.
|
|
@rrhyne (or someone else from @sourcegraph/design), can you please review that the updated icons are OK? |
|
I don't have context for all the icons, but based on the details these changes look good to me! I have a slight preference for |
|
All the other changes here are logical as well. @slimsag please note Julianna's comment that when updating the icon library, the book-open-variant icon that we use for API docs has been changed to have text in it. If we want it to remain blank, we need to change it to book-open-blank-variant. before: after: I suggest we merge this PR without that change to get the cloud icon sync change complete. |
|
I'll update the book icon to use the blank version since that seems to be more desired :) |
Updates
mdi-reactto latest version in order to fix #26016Last sync time icon has been changed to
weather-cloudy-clock(fixes The last sync time icon is misleading #26016)Some icons have been renamed in the new version of MDI:
user->accountusers->account-multipledo-not-disturb->minus-circleerror->alert-circleThe
amazonicon has been removed from the latest MDI. I've replaced with theawsicon which should be fine for the one scenario we use it in (adding a repo from AWS Code Commit).The
cancelicon has been flipped in the latest MDI to match other icons with the same symbol and meaning (e.g.account-cancel)The
book-open-varianticon that we use for API docs has been changed to have text in it. I have changed it tobook-open-blank-variantso it remains blank.