Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: allow to instantiate an empty AsyncTestCase #3374

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions tornado/test/testing_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,15 @@ def test_subsequent_wait_calls(self):
self.io_loop.add_timeout(self.io_loop.time() + 0.2, self.stop)
self.wait(timeout=0.4)

def test_empty_instantation_is_allowed(self):
"""
Test that empty instatiation of an AsyncTestCase is allowed.

unittest.TestCase docs guarantee this working, and pytest's unittest
support relies on it.
"""
AsyncTestCaseTest()


class LeakTest(AsyncTestCase):
def tearDown(self):
Expand Down
12 changes: 11 additions & 1 deletion tornado/testing.py
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,17 @@ def __init__(self, methodName: str = "runTest") -> None:
# the test will silently be ignored because nothing will consume
# the generator. Replace the test method with a wrapper that will
# make sure it's not an undecorated generator.
setattr(self, methodName, _TestMethodWrapper(getattr(self, methodName)))
try:
test_method = getattr(self, methodName)
except AttributeError:
if methodName != "runTest":
# We allow instantiation with no explicit method name
# but not an *incorrect* or missing method name.
raise ValueError(
"no such test method in %s: %s" % (self.__class__, methodName)
)
else:
setattr(self, methodName, _TestMethodWrapper(test_method))

# Not used in this class itself, but used by @gen_test
self._test_generator = None # type: Optional[Union[Generator, Coroutine]]
Expand Down