testing: allow to instantiate an empty AsyncTestCase #3374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`unittest.TestCase` has a feature where it allows instantiating `MyTestClass()` with the default method name `runTest` even if a `runTest` method doesn't actually exist. This is documented in `TestCase`'s docs under "Changed in version 3.2"[0]. Since version 8.2, pytest relies on this, and started breaking on Tornado's `AsyncTestCase`[1]. Change `AsyncTestCase` to allow empty instatiation, by matching the upstream code. [0] https://docs.python.org/3/library/unittest.html#unittest.TestCase [1] pytest-dev/pytest#12263
MichaIng
added a commit
to motioneye-project/motioneye
that referenced
this pull request
May 11, 2024
The motion package installs a motion systemd service, which can block camera devices and hence conflict with the motionEye-controlled motion processes. We hence need to assure that this service is stopped and disabled, before we can start and enable out motioneye.service. Additionally, Tornado python tests are ignored, until a related fix has been merged: tornadoweb/tornado#3374 Signed-off-by: MichaIng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unittest.TestCasehas a feature where it allows instantiatingMyTestClass()with the default method namerunTesteven if arunTestmethod doesn't actually exist. This is documented inTestCase's docs under "Changed in version 3.2" (link).Since version 8.2, pytest relies on this, and started breaking on Tornado's
AsyncTestCase, see pytest-dev/pytest#12263.Change
AsyncTestCaseto allow empty instatiation, by matching the upstream code.