Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: allow to instantiate an empty AsyncTestCase #3374

Closed
wants to merge 1 commit into from

Commits on Apr 28, 2024

  1. testing: allow to instantiate an empty AsyncTestCase

    `unittest.TestCase` has a feature where it allows instantiating
    `MyTestClass()` with the default method name `runTest` even if a
    `runTest` method doesn't actually exist. This is documented in
    `TestCase`'s docs under "Changed in version 3.2"[0].
    
    Since version 8.2, pytest relies on this, and started breaking on
    Tornado's `AsyncTestCase`[1].
    
    Change `AsyncTestCase` to allow empty instatiation, by matching the
    upstream code.
    
    [0] https://docs.python.org/3/library/unittest.html#unittest.TestCase
    [1] pytest-dev/pytest#12263
    bluetech committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    c851aa8 View commit details
    Browse the repository at this point in the history