Android notification structure #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsen340
changed the title
To give more power to the client implementation for how to present notifications we move away from triggering system native notifications and just move to a plain data object container. This will help with extending the data model in the future.
xla
force-pushed
the
android-notification-structure
branch
from
9ba186e to
8315502
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android notification structure
The current structure of the notification payload on android does not allow for customisation on the client side. When a
notificationobject is present the only customisation possible is the notification icon and the primary color.Proposed solution
Replace the notification message with a data message. Documentation on both types can be found here
notificationobject to thedataobject.dataobject on the top levelnotificationobject.The names of the fields in the
notificationobject could be the same in thedataobject. This way the client has to manually handle their notifications, which gives it the liberty to customise the design.This solution would also be more extensible than the previous solution as it allows for custom fields (i.e. user avatars etc).