Skip to content

Commit

Permalink
Merge pull request #31 from tapglue/android-notification-structure
Browse files Browse the repository at this point in the history
Android notification structure
  • Loading branch information
xla authored Dec 8, 2016
2 parents dd80531 + 8315502 commit f68774e
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 1 deletion.
16 changes: 16 additions & 0 deletions doc/notifications-structure-android.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Android notification structure

The current structure of the notification payload on android does not allow for customisation on the client side. When a `notification` object is present the only customisation possible is the notification icon and the primary color.

## Proposed solution

Replace the notification message with a data message. Documentation on both types can be found [here](https://firebase.google.com/docs/cloud-messaging/concept-options#notifications_and_data_messages)

1. Add the data from the `notification` object to the `data` object.
2. Put the `data` object on the top level
2. Remove the `notification` object.

The names of the fields in the `notification` object could be the same in the `data` object. This way the client has to manually handle their notifications, which gives it the liberty to customise the design.

This solution would also be more extensible than the previous solution as it allows for custom fields (i.e. user avatars etc).

2 changes: 1 addition & 1 deletion platform/sns/sns.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const (
fmtURN = `%s://%s`
msgAPNS = `{"APNS": "{\"aps\": {\"alert\": \"%s\"}, \"urn\":\"%s\"}" }`
msgAPNSSandbox = `{"APNS_SANDBOX": "{\"aps\": {\"alert\": \"%s\"}, \"urn\":\"%s\"}" }`
msgGCM = `{"GCM": "{\"notification\": {\"title\": \"%s\", \"data\": {\"urn\": \"%s\"}} }"}`
msgGCM = `{"GCM": "{\"data\": {\"title\": \"Social\", \"body\": \"%s\", \"urn\": \"%s\"} }" }`
)

// PlatformIdentifiers helps to map Platfrom to human-readable strings.
Expand Down

0 comments on commit f68774e

Please sign in to comment.