Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android notification structure #31

Merged
merged 4 commits into from
Dec 8, 2016
Merged

Android notification structure #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8e9610b
Initial commit for the android notification structure PR
nilsen340 Dec 8, 2016
9e538f5
fix typos
nilsen340 Dec 8, 2016
58ce105
add further specification to android notification structure
nilsen340 Dec 8, 2016
8315502
Update GCM mesasge structure
Dec 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions doc/notifications-structure-android.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Android notification structure

The current structure of the notification payload on android does not allow for customisation on the client side. When a `notification` object is present the only customisation possible is the notification icon and the primary color.

## Proposed solution

Replace the notification message with a data message. Documentation on both types can be found [here](https://firebase.google.com/docs/cloud-messaging/concept-options#notifications_and_data_messages)

1. Add the data from the `notification` object to the `data` object.
2. Put the `data` object on the top level
2. Remove the `notification` object.

The names of the fields in the `notification` object could be the same in the `data` object. This way the client has to manually handle their notifications, which gives it the liberty to customise the design.

This solution would also be more extensible than the previous solution as it allows for custom fields (i.e. user avatars etc).

2 changes: 1 addition & 1 deletion platform/sns/sns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const (
fmtURN = `%s://%s`
msgAPNS = `{"APNS": "{\"aps\": {\"alert\": \"%s\"}, \"urn\":\"%s\"}" }`
msgAPNSSandbox = `{"APNS_SANDBOX": "{\"aps\": {\"alert\": \"%s\"}, \"urn\":\"%s\"}" }`
msgGCM = `{"GCM": "{\"notification\": {\"title\": \"%s\", \"data\": {\"urn\": \"%s\"}} }"}`
msgGCM = `{"GCM": "{\"data\": {\"title\": \"Social\", \"body\": \"%s\", \"urn\": \"%s\"} }" }`
)

// PlatformIdentifiers helps to map Platfrom to human-readable strings.
Expand Down