build: fix conditional install_requires
#581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix conditional `install_requires` in `setup.py` to use environment markers instead of inline conditions. The latter do not work correctly with universal wheels -- e.g. a wheel made on Python 3.12 would not have a dependency on `typing-extensions` at all, even if it were installed on Python 3.11 or older, and the other way around.
justinmk
changed the title
install_requiresinstall_requires
|
Thanks! |
Closed
jamessan
added a commit
to jamessan/pynvim
that referenced
this pull request
Nov 13, 2024
- a2adeec build: fix conditional install_requires neovim#581 - 31550a7 fix: remove deprecated universal wheels setting - a6175a4 fix(ci): macOS CI failing with python{3.7, 3.8, 3.9} - 648b0c7 fix(ci): do not use matrix variables for OS-specific commands
rdipardo
added a commit
to rdipardo/vim-cpywrite
that referenced
this pull request
Nov 30, 2024
The issue with pynvim 0.5.1 not pulling in all its dependencies has been fixed upstream: neovim/pynvim#581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix conditional
install_requiresinsetup.pyto use environment markers instead of inline conditions. The latter do not work correctly with universal wheels -- e.g. a wheel made on Python 3.12 would not have a dependency ontyping-extensionsat all, even if it were installed on Python 3.11 or older, and the other way around.