Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish version 0.5.1 #577

Closed
svermeulen opened this issue Oct 29, 2024 · 11 comments
Closed

Publish version 0.5.1 #577

svermeulen opened this issue Oct 29, 2024 · 11 comments
Labels

Comments

@svermeulen
Copy link

There are some subtle bugs that currently completely break remote python plugins for some users on windows, and which are fixed in the preview version, but not in the published 0.5.0 version. In particular, this bug. I find myself recommending people install directly from git url instead often and see people lose a lot of time to this. Is there a reason 0.5.1 still isn't published?

@justinmk
Copy link
Member

justinmk commented Oct 29, 2024

Looks like @jamessan did the last release?

This repo is currently lacking an owner. I've given a lot of attention to https://github.com/neovim/node-client/ , but pynvim needs help.

@jamessan
Copy link
Member

I'd be glad to push the buttons for another release, but I'd like to see #571 fixed first.

@wookayin
Copy link
Member

wookayin commented Nov 3, 2024

Completed in #580. https://pypi.org/project/pynvim/0.5.1/

@wookayin wookayin closed this as completed Nov 3, 2024
@kiyoon
Copy link

kiyoon commented Nov 12, 2024

This version is broken because of the lack of typing_extensions as I mentioned in #582. Shouldn't it be hot-fixed asap as it's a fatal bug?

@jamessan
Copy link
Member

@kiyoon Is this what #581 fixed?

@kiyoon
Copy link

kiyoon commented Nov 12, 2024

@jamessan that also fixed a similar issue but if you open the 0.5.1 version, there is no typing_extensions at all! So there must be another commit that fixed it

@jamessan
Copy link
Member

If I build a wheel from the current master, then I see typing_extensions showing up:

Requires-Dist: typing-extensions >=4.5 ; python_version < "3.12"

so that should be good, right?

@kiyoon
Copy link

kiyoon commented Nov 13, 2024

@jamessan that looks good to me, and from what @wookayin confirmed in #582 (comment), it should have been fixed by #581

@kiyoon
Copy link

kiyoon commented Nov 14, 2024

Now that the new version is released, I suggest yanking the broken version on PyPI. This way, it won't let users accidentally install the problematic version, but it is still available to download if users specifically ask for the version.

@jamessan
Copy link
Member

Now that the new version is released, I suggest yanking the broken version on PyPI.

I don't have access to do that. I think @bfredl or @justinmk would need to do that, if we wanted to.

@bfredl
Copy link
Member

bfredl commented Nov 14, 2024

@jamessan congratulations, you are now a co-owner of the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants