Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing_extensions should be a dependency #582

Closed
kiyoon opened this issue Nov 11, 2024 · 3 comments
Closed

typing_extensions should be a dependency #582

kiyoon opened this issue Nov 11, 2024 · 3 comments
Labels

Comments

@kiyoon
Copy link

kiyoon commented Nov 11, 2024

Fresh-installing pynvim on a new environment will fail to import the module due to the lack of typing_extensions (at least in Python 3.9). Thus the package should be listed as a dependency, maybe depending on the python version.

@kiyoon
Copy link
Author

kiyoon commented Nov 11, 2024

I think it's already addressed in the master branch, but maybe not the pypi version 0.5.1. Sorry! Closing as completed

@wookayin
Copy link
Member

wookayin commented Nov 12, 2024

While I can see that this has been fixed in #581, I don't see why CI hadn't been unable to catch this (before #581 was merged).

EDIT: I got it, the following is still executed during pip install -e., but this dependency is not published to PyPI as the release was made with python >= 3.12. We should make a new release anyway; thanks for reporting.

if sys.version_info < (3, 12):
    install_requires.append('typing-extensions>=4.5')

@wookayin wookayin added the bug label Nov 12, 2024
@kiyoon
Copy link
Author

kiyoon commented Nov 12, 2024

@wookayin ahh that makes sense. Very interesting bug! Thanks for investigating :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants