Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump golangci-lint #2490

Merged
merged 2 commits into from
Jun 6, 2023
Merged

bump golangci-lint #2490

merged 2 commits into from
Jun 6, 2023

Conversation

zirain
Copy link
Member

@zirain zirain commented Jun 5, 2023

depguard upgrade to v2, see golangci/golangci-lint#3795

@zirain zirain requested a review from a team as a code owner June 5, 2023 07:17
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 5, 2023
common/config/.golangci.yml Outdated Show resolved Hide resolved
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check that istio/istio update works? it has complex depguard usage

@ericvn
Copy link
Contributor

ericvn commented Jun 5, 2023

As a note on how to do the testing, you can build a new build-tools image with make containers-test. You need to let it run long enough for it to create a new build-tools image of the form: ${HUB}/build-tools:master-latest-<architecture>. Then you can use this image to run the various make commands.

In this case, go to istio/istio and run something like IMG=ericvn/build-tools:master-latest-amd64 make lint.
This will cause a number of dep-guard errors.

You will need to understand that the golangci.yml from common-files gets updated with an override from the istio/istio/tools/golangci-override.yaml.

I believe you can work on the dep-guard messages, but will have to update the override file with those specific to istio/istio so that the common-files file is updated corrected.

@zirain zirain added the do-not-merge Block automatic merging of a PR. label Jun 6, 2023
@zirain
Copy link
Member Author

zirain commented Jun 6, 2023

@howardjohn @ericvn
create a test PR: istio/istio#45300

Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@howardjohn howardjohn removed the do-not-merge Block automatic merging of a PR. label Jun 6, 2023
@istio-testing istio-testing merged commit 50b6b70 into master Jun 6, 2023
8 checks passed
@istio-testing istio-testing deleted the bump-golangci-lint branch June 6, 2023 15:11
shalier pushed a commit to shalier/tools that referenced this pull request Feb 13, 2024
* bump golangci-lint

* revert .golangci.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
4 participants