Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automator: update build-tools image@master in istio/common-files@master #845

Closed
wants to merge 1 commit into from
Closed

Automator: update build-tools image@master in istio/common-files@master #845

wants to merge 1 commit into from

Conversation

istio-testing
Copy link
Contributor

@istio-testing istio-testing commented Jun 6, 2023 •
edited
Loading

Generated by Automator - 2023-06-06T20:42:11+00:00

@istio-testing istio-testing force-pushed the master-master-update_image_version-e8515a01 branch from ca5e537 to 7432c91 Compare June 6, 2023 15:44
@istio-testing istio-testing requested a review from a team as a code owner June 6, 2023 15:44
@istio-testing istio-testing added release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 6, 2023
@ericvn
Copy link
Contributor

ericvn commented Jun 6, 2023

Contains istio/tools#2490

@ericvn
Copy link
Contributor

ericvn commented Jun 6, 2023 •
edited
Loading

Running IMG=gcr.io/istio-testing/build-tools:master-50b6b707c27345bee1732483d860472ff1eb0859 make clean build docker.proxyv2 gen lint in istio/istio.

@ericvn
Copy link
Contributor

ericvn commented Jun 6, 2023

As expected, we have some dup-guard issues which will be resolved with changes ike istio/istio#45300.

Checking some other repos.

@ericvn
Copy link
Contributor

ericvn commented Jun 6, 2023 •
edited
Loading

Failing in Istio.io as well. Checking again with the sample department-guard common-files change in istio/tools@4f274f3

@ericvn
Copy link
Contributor

ericvn commented Jun 6, 2023

The small common-files update fixes istio.io, api and tools so expect it will cover all but the istio changes which are in another PR.

If we add the small change into this PR it should flow to the other repos.

@ericvn ericvn mentioned this pull request Jun 6, 2023
Merged
@ericvn
Copy link
Contributor

ericvn commented Jun 6, 2023 •
edited
Loading

I see we have a more comprehensive depguard change in #844? Probably easier to pull the image change from here into that PR.

@istio-testing istio-testing force-pushed the master-master-update_image_version-e8515a01 branch from 7432c91 to 91b2004 Compare June 6, 2023 21:27
@zirain
Copy link
Member

zirain commented Jun 7, 2023

Failing in Istio.io as well. Checking again with the sample department-guard common-files change in istio/tools@4f274f3

see https://github.com/istio/istio.io/pull/13305/files

@ericvn ericvn added the do-not-merge Block automatic merging of a PR. label Jun 8, 2023
@ericvn
Copy link
Contributor

ericvn commented Jun 8, 2023 •
edited
Loading

Making this one DNM as we'll want to pull in the depguard config changes with the IMG update. Easiest to do in that PR.

@ericvn
Copy link
Contributor

ericvn commented Jun 8, 2023

Superseded by #844.

@ericvn ericvn closed this Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge Block automatic merging of a PR. release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
3 participants
@istio-testing @ericvn @zirain