upgrade depguard to v2

[zirain]

related to istio/tools#2490

[zirain]

/hold

wait istio/tools#2490

[zirain]

delete these lines after build-image upgraded

[ericvn]

thanks. I think this is close to what I test in the other repos. I'll give it a another try in them in the morning and if things work, I think we can try merging this.

[zirain]

maybe we should add test for this,
checkout code from other repo then run make lint?

[ericvn]

I believe the processing here is a little bit circular, and that's what we need to take into consideration. When a common-files PR merges, there are a number of post-submit jobs. One set is related to calling make update-common in the various repos updating their common-files to match the submitted PR. Another job updates the test-infra file job definitions to use the new image in the pipeline. Normally, we let the first set of jobs update the common-files to make sure everything seems OK, then we update the pipeline to use the new image.

Note that the first set of PRs across the repos still use the image called out in the pipeline, and I think this is one of the cases, we need to be a little different. Since the repo PRs will have the new .golangci.yml but using the existing pipeline image, those PRs will fail the lint-go. We can work around that by merging the image updating PR in test-infra right away. This should cause the pipeline jobs to use the new image and we will have the new .golangci.yml in common.

The question is if what we have here will work across all the repos.

[ericvn]

Comments (with editing as the repos are tested)

Running IMG=gcr.io/istio-testing/build-tools:master-8fd7512ff351aebc342a7c6410dd4899811de4ef make lint-go after replacing common/config/.golangci.yml with changes from this PR.

test-infra: OK
bots: OK
community: OK
istio (will also have override changes):tested OK previously with test PR.
api: OK
tools: OK
release-builder: OK
client-go: OK
proxy: FAILED (but failed without change).

test/envoye2e/env/wasm.go:53:37: octalLiteral: use new octal literal style, 0o666 (gocritic)
		err = os.WriteFile(file, content, 0666)

ztunnel: OK

[ericvn]

@howardjohn Any last minute thoughts on merging this and merging the test-infra right away so the lint test passes in the repos.

[howardjohn]

TBH I don't really get the problem, lets just merge something :-)

[ericvn]

OK. Removing DNM.