1010: Upgrade react native

[steffenkleinle]

Short description

Upgrade react-native to v0.74.

Proposed changes

• Upgrade react-native to v0.74
• Upgrade all libraries except
  • @react-navigation: Really new release with a lot of changes so I think its better to wait a bit (see https://reactnavigation.org/docs/upgrading-from-6.x)
  • react-native-screens: Really new release with a lot of changes so I think its better to wait a bit (see https://github.com/software-mansion/react-native-screens/releases/tag/4.0.0)
  • eslint: v9 breaks all plugins/configs that are not updated yet to support the new format
  • victory-native: Upgrade victory-native #1011

Side effects

• Hopefully none

Testing

Please test the whole app, specifically the code scanner (under Lernbereiche verwalten), the camera, image picker from the gallery and the audio recording (under Eigene Vokablen

Resolved issues

Fixes: #1010, #890

---

[LeandraH]

Amazing, thank you! Looks pretty good already, I could scan a QR code, I could use a picture from the gallery, and I could record a pronunciation when creating a new Vokabel, this all in real iOS 🥳

I unfortunately also got two errors:

When trying to create a new Vokabel with a picture that I took with the camera within the app, I could take the picture but when hitting "Speichern", I got the following error:

Sentry reported error: [Error: “65893640-A69A-479F-B510-1BEF31C1F5CA.jpg” couldn’t be moved to “Documents” because either the former doesn’t exist, or the folder containing the latter doesn’t exist.]

After adding my own Vokabel with a picture from the gallery (which all worked), I could not open the card from the Vokabelliste, and got the following error message:

Do you have a screen named 'UserVocabularyDetail'?

If you're trying to navigate to a screen in a nested navigator, see https://reactnavigation.org/docs/nesting-navigators#navigating-to-a-screen-in-a-nested-navigator.

This is a development-only warning and won't be shown in production.```

[LeandraH]

Oh, I also started getting a bunch of these warnings in my console:

(ADVICE) View #1234 of type RCTView has a shadow set but cannot calculate shadow efficiently. Consider setting a solid background color to fix this, or apply the shadow to a more specific component

It might be related to this: https://stackoverflow.com/questions/75355104/view-has-a-shadow-set-but-cannot-calculate-shadow-efficiently-in-react-native

[steffenkleinle]

When trying to create a new Vokabel with a picture that I took with the camera within the app, I could take the picture but when hitting "Speichern", I got the following error:

Sentry reported error: [Error: “65893640-A69A-479F-B510-1BEF31C1F5CA.jpg” couldn’t be moved to “Documents” because either the former doesn’t exist, or the folder containing the latter doesn’t exist.]

This happens on iOS only, correct? Did you test in both simulator/real device? Also, does this always happen or just sometimes?

After adding my own Vokabel with a picture from the gallery (which all worked), I could not open the card from the Vokabelliste, and got the following error message:

Do you have a screen named 'UserVocabularyDetail'?
If you're trying to navigate to a screen in a nested navigator, see https://reactnavigation.org/docs/nesting-navigators#navigating-to-a-screen-in-a-nested-navigator.`

I just checked and it seems like the problem already exists on main. I'll create an issue: #1037

[LeandraH]

When trying to create a new Vokabel with a picture that I took with the camera within the app, I could take the picture but when hitting "Speichern", I got the following error:
Sentry reported error: [Error: “65893640-A69A-479F-B510-1BEF31C1F5CA.jpg” couldn’t be moved to “Documents” because either the former doesn’t exist, or the folder containing the latter doesn’t exist.]

This happens on iOS only, correct? Did you test in both simulator/real device? Also, does this always happen or just sometimes?

I just tested it again, I couldn't open the camera at all in emulated iOS. In real iOS, I got the error in three out of three attempts.

[steffenkleinle]

Oh, I also started getting a bunch of these warnings in my console:

(ADVICE) View #1234 of type RCTView has a shadow set but cannot calculate shadow efficiently. Consider setting a solid background color to fix this, or apply the shadow to a more specific component

It might be related to this: https://stackoverflow.com/questions/75355104/view-has-a-shadow-set-but-cannot-calculate-shadow-efficiently-in-react-native

@LeandraH I sadly can't reproduce this, can you tell where exactly you get those?

[steffenkleinle]

When trying to create a new Vokabel with a picture that I took with the camera within the app, I could take the picture but when hitting "Speichern", I got the following error:
Sentry reported error: [Error: “65893640-A69A-479F-B510-1BEF31C1F5CA.jpg” couldn’t be moved to “Documents” because either the former doesn’t exist, or the folder containing the latter doesn’t exist.]

This happens on iOS only, correct? Did you test in both simulator/real device? Also, does this always happen or just sometimes?

I just tested it again, I couldn't open the camera at all in emulated iOS. In real iOS, I got the error in three out of three attempts.

I fixed the issue on the simulator (camera is not available but now the overlay is opened and an image can be selected). Selecting an image from the gallery and saving a new vocab works for me on simulated iOS.

Sadly, I have no way of investigating real iOS, could you perhaps take over @LeandraH? Thanks!

[LeandraH]

Woohoo! Tested on real iOS

[ztefanie]

Thanks for taking care of this update ❤️

Tested on Android real device and found a few errors:

adding a new word: Could not add a audio record for a new custom word. Error "startRecorder has already been called".
Steps to reproduce: "Meine Wörter" -> "Vokabel erstellen" -> "Audio aufnehmen" -> click on mircophone-icon -> See error

Adding a new word -> then go to the list of my words -> click on the item -> Error: "the action "navigate" with payload was not handled"

Menu is shown when navigating back on home screen after settings. Steps to reproduce: open home screen -> go to menu -> open "Lernbereiche verwalten" -> click "back". See menu is open on homescreen. Would expect it to be closed

[steffenkleinle]

adding a new word: Could not add a audio record for a new custom word. Error "startRecorder has already been called". Steps to reproduce: "Meine Wörter" -> "Vokabel erstellen" -> "Audio aufnehmen" -> click on mircophone-icon -> See error

Hmm, I guess I'll have another look. I really thought I tested this thoroughly and there were no more errors :/

Adding a new word -> then go to the list of my words -> click on the item -> Error: "the action "navigate" with payload was not handled"

See #1037, already happens on main as well.

Menu is shown when navigating back on home screen after settings. Steps to reproduce: open home screen -> go to menu -> open "Lernbereiche verwalten" -> click "back". See menu is open on homescreen. Would expect it to be closed

This is the same behavior as on main, please open a new issue, I think this PR is big enough already :)

[ztefanie]

Menu is shown when navigating back on home screen after settings. Steps to reproduce: open home screen -> go to menu -> open "Lernbereiche verwalten" -> click "back". See menu is open on homescreen. Would expect it to be closed

#1046