Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

873: Use react-native-vision-camera and react-native-image-picker #1034

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

873: Use react-native-vision-camera and react-native-image-picker #1034

wants to merge 5 commits into from

Conversation

steffenkleinle
Copy link
Member

@steffenkleinle steffenkleinle commented Oct 31, 2024 •
edited
Loading

Short description

Replaced a few libraries and fixed their usages.

Proposed changes

  • Replace the deprecated react-native-camera with react-native-vision-camera
  • Replace react-native-image-crop-picker with react-native-image-picker (due to smaller size and since the old library was not working for me after the react-native upgrade)
  • Fix react-native-audio-recorder-player by correctly handling short press edge case
  • Some cleanup

Side effects

  • Hopefully none?

Testing

None in this PR, please test ONLY the react-native upgrade follow up PR: #1035.

Resolved issues

Fixes: #873

@steffenkleinle steffenkleinle marked this pull request as draft November 6, 2024 10:49
@steffenkleinle steffenkleinle marked this pull request as ready for review December 4, 2024 16:11
LeandraH
LeandraH approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@LeandraH LeandraH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on real iOS

ztefanie
ztefanie approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@ztefanie ztefanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Not tested as mentioned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeandraH LeandraH LeandraH approved these changes

@ztefanie ztefanie ztefanie approved these changes

@f1sh1918 f1sh1918 Awaiting requested review from f1sh1918 f1sh1918 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LUN-439: Replace react-native-camera
3 participants
@steffenkleinle @ztefanie @LeandraH