Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUN-458: Remove react-native-audio-record-player patch #890

Open
jira-to-github-migrator bot opened this issue Aug 13, 2023 · 0 comments · May be fixed by #1035
Open

LUN-458: Remove react-native-audio-record-player patch #890

jira-to-github-migrator bot opened this issue Aug 13, 2023 · 0 comments · May be fixed by #1035
Assignees

Comments

@jira-to-github-migrator
Copy link

f1sh1918 - 22.11.2022, 10:46:02

There were three issues to be fixed by a patch for
react-native-audio-record-player 3.5.1
If the next update fixes these issues, this patch should be removed

https://github.com/hyochan/react-native-audio-recorder-player

 

Acceptance Criteria

  • remove patch
  • remove patchfiles
  • unlock package in package.json
  • remove dev dependency "patch-package"
  • remove postinstall

 

Note

These issues were patched.

  • In the kotlin file the external storage will not be requested in any case. A future version should check the passed path if its external or internal.
  • The "External Storage" permission was removed from the manifest.
  • Types were fixed that caused errors in unit tests

Environment: -
Linked issues:

This was referenced Mar 26, 2024
@steffenkleinle steffenkleinle self-assigned this Oct 29, 2024
@steffenkleinle steffenkleinle linked a pull request Oct 31, 2024 that will close this issue
@steffenkleinle steffenkleinle linked a pull request Oct 31, 2024 that will close this issue
@steffenkleinle steffenkleinle moved this from In Progress to In Review in team-app Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

1 participant