-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1010: Upgrade react native #1035
base: 873-react-native-vision-camera
Are you sure you want to change the base?
1010: Upgrade react native #1035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thank you! Looks pretty good already, I could scan a QR code, I could use a picture from the gallery, and I could record a pronunciation when creating a new Vokabel, this all in real iOS 🥳
I unfortunately also got two errors:
When trying to create a new Vokabel with a picture that I took with the camera within the app, I could take the picture but when hitting "Speichern", I got the following error:
Sentry reported error: [Error: “65893640-A69A-479F-B510-1BEF31C1F5CA.jpg” couldn’t be moved to “Documents” because either the former doesn’t exist, or the folder containing the latter doesn’t exist.]
After adding my own Vokabel with a picture from the gallery (which all worked), I could not open the card from the Vokabelliste, and got the following error message:
Do you have a screen named 'UserVocabularyDetail'?
If you're trying to navigate to a screen in a nested navigator, see https://reactnavigation.org/docs/nesting-navigators#navigating-to-a-screen-in-a-nested-navigator.
This is a development-only warning and won't be shown in production.```
Oh, I also started getting a bunch of these warnings in my console:
It might be related to this: https://stackoverflow.com/questions/75355104/view-has-a-shadow-set-but-cannot-calculate-shadow-efficiently-in-react-native |
f19d5ab
to
d109f0e
Compare
This happens on iOS only, correct? Did you test in both simulator/real device? Also, does this always happen or just sometimes?
I just checked and it seems like the problem already exists on main. I'll create an issue: #1037 |
I just tested it again, I couldn't open the camera at all in emulated iOS. In real iOS, I got the error in three out of three attempts. |
@LeandraH I sadly can't reproduce this, can you tell where exactly you get those? |
I fixed the issue on the simulator (camera is not available but now the overlay is opened and an image can be selected). Selecting an image from the gallery and saving a new vocab works for me on simulated iOS. Sadly, I have no way of investigating real iOS, could you perhaps take over @LeandraH? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo! Tested on real iOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this update ❤️
Tested on Android real device and found a few errors:
adding a new word: Could not add a audio record for a new custom word. Error "startRecorder has already been called".
Steps to reproduce: "Meine Wörter" -> "Vokabel erstellen" -> "Audio aufnehmen" -> click on mircophone-icon -> See error
Adding a new word -> then go to the list of my words -> click on the item -> Error: "the action "navigate" with payload was not handled"
Menu is shown when navigating back on home screen after settings. Steps to reproduce: open home screen -> go to menu -> open "Lernbereiche verwalten" -> click "back". See menu is open on homescreen. Would expect it to be closed
Hmm, I guess I'll have another look. I really thought I tested this thoroughly and there were no more errors :/
See #1037, already happens on main as well.
This is the same behavior as on main, please open a new issue, I think this PR is big enough already :) |
|
Short description
Upgrade react-native to v0.74.
Proposed changes
Side effects
Testing
Please test the whole app, specifically the code scanner (under
Lernbereiche verwalten
), the camera, image picker from the gallery and the audio recording (underEigene Vokablen
Resolved issues
Fixes: #1010, #890