Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1286: Improve error message activation #1593

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

f1sh1918
Copy link
Contributor

@f1sh1918 f1sh1918 commented Aug 26, 2024

Short description

Some users seem to scan the static verification code (physical pass) for activation instead of the activation code.
First there was an unknown error report.
To be able to get proper error information we send the information to Sentry. Since we identified the issue the error reporting to Sentry can be removed

Proposed changes

  • improve the error message to indicate the user what should be scanned
  • remove sending error reports to sentry, since this is an intended error and displays error information to to the user

Side effects

  • none

Testing

  1. Create a card for nuernberg
  2. add screenshot of the static qr code to the emulator/ or scan it with real device
  3. try to activate the card and check error message

Resolved issues

Fixes: #1286

Copy link
Contributor

@seluianova seluianova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@f1sh1918 f1sh1918 merged commit 1022f5d into main Sep 2, 2024
1 check passed
@f1sh1918 f1sh1918 deleted the 1286-improve-error-message-activation branch September 2, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beim Scannen des QR-Codes ist ein unbekannter Fehler aufgetreten.
3 participants