Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1286: Improve qr code error handling #1332

Merged
merged 4 commits into from
Mar 11, 2024
Merged

1286: Improve qr code error handling #1332

merged 4 commits into from
Mar 11, 2024

Conversation

f1sh1918
Copy link
Contributor

@f1sh1918 f1sh1918 commented Mar 5, 2024

Short description

As we get very unspecific error messages in #1286 we can not really identify the issue why codes can not be scanned properly

Proposed changes

  • add stacktrace AcitvationCodeParser Exception()
  • show proper message if an invalid type was scanned (f.e. static verification code on activation)
  • improve error message for unknown qrCode (i do not know if we can do better here thant send the stacktrace)

michael-markl
michael-markl approved these changes Mar 6, 2024
View reviewed changes
frontend/assets/l10n/app_en.json Outdated Show resolved Hide resolved
frontend/assets/l10n/app_de.json Outdated Show resolved Hide resolved
@f1sh1918 f1sh1918 merged commit 32b770f into main Mar 11, 2024
1 check passed
@f1sh1918 f1sh1918 deleted the 1286-improve-qr-code-error-handling branch March 11, 2024 09:03
@f1sh1918 f1sh1918 mentioned this pull request Mar 25, 2024
Closed
@f1sh1918 f1sh1918 mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-markl michael-markl michael-markl approved these changes

@steffenkleinle steffenkleinle Awaiting requested review from steffenkleinle steffenkleinle is a code owner

@sarahsporck sarahsporck Awaiting requested review from sarahsporck

@ztefanie ztefanie Awaiting requested review from ztefanie ztefanie is a code owner

Assignees
No one assigned
Labels
not-testable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@f1sh1918 @michael-markl