Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1232: Create github release #1390

Merged
merged 5 commits into from
Apr 29, 2024
Merged

1232: Create github release #1390

merged 5 commits into from
Apr 29, 2024

Conversation

f1sh1918
Copy link
Contributor

@f1sh1918 f1sh1918 commented Apr 11, 2024

Short description

As a dev i want that after successful delivery a github release with release notes will be created.

Proposed changes

  • add notify_release job to create a release, generate release notes, upload artifacts and send mattermost notification to release channel

Resolved issues

digitalfabrik/app-toolbelt#13 (merged)
resolves #1232, resolves #1319, resolves #1331, resolves #1165

Testing (dev only)

  1. Important deactivate delivery tasks in deliver_beta_native(!!!)
  2. Push your commit
 curl -X POST https://circleci.com/api/v2/project/github/digitalfabrik/entitlementcard/pipeline \
  --header "Circle-Token: <"your token">" \
  --header "content-type: application/json" \
  --data '{"branch":"1232-create-github-release", "parameters":{"run_delivery_beta_native":true, "run_commit":false}}'

@f1sh1918 f1sh1918 force-pushed the 1232-create-github-release branch 13 times, most recently from 03be854 to 4246d21 Compare April 11, 2024 11:37
@f1sh1918 f1sh1918 force-pushed the 1232-create-github-release branch 8 times, most recently from 5fe133c to 0d07358 Compare April 15, 2024 16:26
@f1sh1918 f1sh1918 force-pushed the 1232-create-github-release branch from 0d07358 to 7850d5d Compare April 15, 2024 16:43
@f1sh1918 f1sh1918 marked this pull request as ready for review April 15, 2024 19:39
.circleci/src/jobs/notify_release.yml Outdated Show resolved Hide resolved
.circleci/src/jobs/notify_release.yml Outdated Show resolved Hide resolved
.circleci/src/jobs/notify_release.yml Outdated Show resolved Hide resolved
@f1sh1918 f1sh1918 requested a review from ztefanie April 17, 2024 08:08
@f1sh1918 f1sh1918 requested a review from seluianova as a code owner April 22, 2024 08:47
@f1sh1918 f1sh1918 force-pushed the 1232-create-github-release branch from 63525bb to f39c555 Compare April 22, 2024 08:49
@f1sh1918 f1sh1918 force-pushed the 1232-create-github-release branch 2 times, most recently from 552b90b to a7b55d3 Compare April 23, 2024 07:25
Copy link
Member

@ztefanie ztefanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR. 👍

.circleci/config.yml Show resolved Hide resolved
@f1sh1918 f1sh1918 force-pushed the 1232-create-github-release branch 4 times, most recently from 35d52ff to 6aedc91 Compare April 24, 2024 09:28
@f1sh1918 f1sh1918 force-pushed the 1232-create-github-release branch from 6aedc91 to 27b88a2 Compare April 24, 2024 09:32
@f1sh1918 f1sh1918 requested a review from ztefanie April 24, 2024 09:32
@f1sh1918 f1sh1918 merged commit 4a3ac68 into main Apr 29, 2024
1 check passed
@f1sh1918 f1sh1918 deleted the 1232-create-github-release branch April 29, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants