Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix mamba version and some test file paths #208

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

misialq
Copy link
Contributor

@misialq misialq commented Oct 2, 2024

This PR:

  • fixes mamba version used by the setup_miniconda to 1.5.10 to prevent CI failures cause by mamba 2.0.0
  • updates paths to some test files

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (b56f64b) to head (a88b857).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
- Coverage   98.73%   97.72%   -1.02%     
==========================================
  Files          78       64      -14     
  Lines        4671     4615      -56     
  Branches        0      386     +386     
==========================================
- Hits         4612     4510     -102     
+ Misses         59       57       -2     
- Partials        0       48      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@misialq misialq requested a review from VinzentRisch October 2, 2024 10:10
@VinzentRisch
Copy link
Contributor

Everything looks good.
But the codecov report fails it says: Report creating failed: {"message":"Token required because branch is protected"}
I could only find this:
codecov/codecov-action#1580

It says to create a new PR for a workaround but i guess its not that important for this one PR

@VinzentRisch
Copy link
Contributor

Ah I just saw you have two CI checks for coverage and the other one works.
So i guess the other one can be ignored?

@misialq
Copy link
Contributor Author

misialq commented Oct 2, 2024

Hey @VinzentRisch, yeah, I think it's fine if only one of them works - something seems to be off, though, as the coverage for the project could not have changed that much - there were no code changes in this PR. I think I'd just merge this and address the rest in another PR, if necessary - if that's fine with you.

@misialq misialq merged commit a6e3a4d into bokulich-lab:main Oct 3, 2024
8 of 10 checks passed
@misialq misialq deleted the ci-fixes branch October 3, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants