-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test fields #175
Fix test fields #175
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
==========================================
+ Coverage 57.50% 57.70% +0.20%
==========================================
Files 103 103
Lines 26964 26964
==========================================
+ Hits 15505 15560 +55
+ Misses 11459 11404 -55 ☔ View full report in Codecov by Sentry. |
@MatteoSalvador, I would merge this one first, and then I'll fix the conflicts in #174 and #188 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @mrp089, really nice job (as always)!
Before merging, I would only make sure that the .inp
files perfectly match the .xml
for all the test cases, for reproducibility reasons. I saw that sometimes tolerances and other settings have not been updated accordingly.
You mean |
Thanks @mrp089! Following up on our conversation this afternoon, it is probably better to remove the |
Current situation
Closes #173.
Release Notes
NS
toGMRES
)Documentation
Added testing guide #195
Testing
Code of Conduct & Contributing Guidelines