Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test fields #175

Merged
merged 23 commits into from
Feb 23, 2024
Merged

Fix test fields #175

merged 23 commits into from
Feb 23, 2024

Conversation

mrp089
Copy link
Member

@mrp089 mrp089 commented Jan 25, 2024

Current situation

Closes #173.

Release Notes

  • fix test loop to run ALL fields (and report errors for all individually)
  • reran ALL test cases
  • tightened tolerances as much as possible (had to change some linear solvers from NS to GMRES)
  • limited max number of nonlinear steps to the current converged one
  • adapted tolerances for ALL fields we test to the tightest ones with which all tests still pass

Documentation

Added testing guide #195

Testing

  • tests still pass
  • and importantly: didn't pass before adapting the tolerances

Code of Conduct & Contributing Guidelines

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.70%. Comparing base (6c60ff7) to head (9071ad9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   57.50%   57.70%   +0.20%     
==========================================
  Files         103      103              
  Lines       26964    26964              
==========================================
+ Hits        15505    15560      +55     
+ Misses      11459    11404      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrp089 mrp089 marked this pull request as ready for review February 22, 2024 15:47
@mrp089
Copy link
Member Author

mrp089 commented Feb 22, 2024

@MatteoSalvador, I would merge this one first, and then I'll fix the conflicts in #174 and #188

Copy link
Collaborator

@MatteoSalvador MatteoSalvador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @mrp089, really nice job (as always)!

Before merging, I would only make sure that the .inp files perfectly match the .xml for all the test cases, for reproducibility reasons. I saw that sometimes tolerances and other settings have not been updated accordingly.

@mrp089
Copy link
Member Author

mrp089 commented Feb 22, 2024

You mean .inp from FORTRAN svFSI? I tried deleting the remaining ones I found so there are no duplicates.

@MatteoSalvador
Copy link
Collaborator

Thanks @mrp089! Following up on our conversation this afternoon, it is probably better to remove the .inp files from all the test cases and stick with .xml files only.

@mrp089 mrp089 merged commit 2fd02ed into SimVascular:main Feb 23, 2024
7 checks passed
@mrp089 mrp089 deleted the fix_test_fields_173 branch February 23, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Results are only compared for first field in each test
2 participants