-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ustruct and volumetric material tests #229
Ustruct and volumetric material tests #229
Conversation
…2cc_dev was unmodified
…ol_pen(). Also, add/update comments
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
==========================================
+ Coverage 64.96% 65.72% +0.76%
==========================================
Files 116 116
Lines 29153 28876 -277
==========================================
+ Hits 18938 18980 +42
+ Misses 10215 9896 -319 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aabrown100-git, I'm very happy you tackled testing the solid material models!
As someone who has messed up a test-PR before, I have one piece of wisdom: Do your tests fail if you change parts of the code that the test should be sensitive to ("test the test")? You can verify this locally.
Also, thank you for adding comments to your (and existing code)! You could slightly change their format and they would show up in Doxygen. There's a quick guide here (it's mostly converting to ///
or @brief
). There's also a plugin for VS Code that makes it very easy (probably for other editors as well).
Thanks @mrp089 for your comments! |
…nsistent with other material model tests.
…b.com/aabrown100-git/svFSIplus into ustruct_and_volumetric_material_tests
@mrp089 Thanks for the comments!
|
Current situation
Material unit tests do not test ustruct material model implementations, nor volumetric penalty model implementations. #150
Release Notes
Testing
Please ensure that the PR meets the testing requirements set by GitHub Actions.
This code itself is testing.
Code of Conduct & Contributing Guidelines