zlib: link with --undefined-version on lld #307540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin-stdenv
|
Since this causes many rebuilds, shouldn't this be targeted to staging as per CONTRIBUTING.md? |
|
Ah yes, sorry! |
|
Please do rebase this branch to staging, if not already. |
|
done already |
|
oh oops, I misunderstood your request. One sec |
rhelmot
force-pushed
the
freebsd-minimal2/zlib
branch
2 times, most recently
from
f546ad3 to
d78595a
Compare
|
Rebase didn't quite work, but cherry-pick did the trick. |
14 tasks
alyssais
reviewed
Apr 29, 2024
rhelmot
force-pushed
the
freebsd-minimal2/zlib
branch
from
d78595a to
06cbdb9
Compare
|
Bumping this - I linked the mentioned pull request from a comment in the diff. |
This was referenced May 8, 2024
ghost
mentioned this pull request
rrbutani
added
the
6.topic: llvm/clang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
zlib is one of many packages impacted by changes to lld's default flags, wherein it will throw errors unless linked with --undefined-verison or fixed to set its version info correctly. This does the former. This is necessary to build on freebsd.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.