zlib: Fix build with lld 16

[artemist]

Description of changes

Set --undefined-version linker flag when building with lld. This is important for FreeBSD, which uses lld for build. Without this change zlib will fail silently, producing only a man page in the output and causing dependent packages to fail.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[ghost]

isn't this a dup of #307540? and isn't this lld 17+ not 16?

[artemist]

.... I didn't notice that because it went into staging and I was working on master. It is an lld 16 change though, according to the release notes

[ghost]

thanks. perhaps the version checks in some of the PRs i reviewed were off by one then. #309884

[rrbutani]

thanks. perhaps the version checks in some of the PRs i reviewed were off by one then. #309884

@annaleeleaves I mentioned in the commit message in #309884: --no-undefined-version was demoted to a warning for lld 16 (llvm/llvm-project#61208, llvm/llvm-project@c1949c6). This is why the darwin stdenv hasn't started hitting these issues yet.

[ghost]

thanks @rrbutani -- i should've re-read the PR , sorry about that.

[rrbutani]

no worries!