sysbench: Use vendored statically linked libck #309564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrbutani
reviewed
May 6, 2024
|
Just for posterity: ❯ ls $(nix build nixpkgs#libck --print-out-paths --no-link)/lib
libck.a libck.so libck.so.0 libck.so.0.7.1 pkgconfigBut its pkg-config file ( I don't see a good way to get |
|
@ofborg build pkgsCross.aarch64-multiplatform.sysbench pkgsCross.aarch64-multiplatform.pkgsLLVM.sysbench |
rrbutani
added
the
12.approvals: 1
Mic92
reviewed
May 14, 2024
Mic92
reviewed
May 14, 2024
Mic92
reviewed
May 14, 2024
Mic92
force-pushed
the
avnik/sysbench-improvements
branch
from
5968dac to
413f012
Compare
This partially revert and redo 4af1355 Vendored version of concurrency kit (aka libck) require little more patching to support cross-compilation
Mic92
force-pushed
the
avnik/sysbench-improvements
branch
from
413f012 to
2df7707
Compare
wegank
removed
the
12.approvals: 1
brianmcgillion
approved these changes
May 16, 2024
brianmcgillion
added a commit
to brianmcgillion/ghaf
that referenced
this pull request
May 31, 2024
fixed in the upstream NixOS/nixpkgs#309564 Signed-off-by: Brian McGillion <[email protected]>
brianmcgillion
added a commit
to tiiuae/ghaf
that referenced
this pull request
Jun 3, 2024
fixed in the upstream NixOS/nixpkgs#309564 Signed-off-by: Brian McGillion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: use shared version of libck in sysbench affect on measurement results too much
Description of changes
This partially revert and redo 4af1355
Vendored version of concurrency kit (aka libck) require little more patching to support cross-compilation
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.