Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CorsairLightingProtocol namespace and naming convention #168

Open
Legion2 opened this issue Aug 10, 2020 · 1 comment
Open

Use CorsairLightingProtocol namespace and naming convention #168

Legion2 opened this issue Aug 10, 2020 · 1 comment
Assignees
Milestone

Comments

@Legion2
Copy link
Owner

Legion2 commented Aug 10, 2020

As described in #101 for the version 1.0.0 a stable API should be provided using the namespace CorsairLightingProtocol.

Moving all definitions into the namespace is a breaking change. In the same turn also some free functions should be renamed to have unambiguous names without the namespace.

All the breaking changes should be documented and a migration path should be given so users can easily upgrade to the stable version.

@stale
Copy link

stale bot commented Sep 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 19, 2020
@stale stale bot closed this as completed Sep 26, 2020
@Legion2 Legion2 reopened this Sep 27, 2020
@stale stale bot removed the wontfix This will not be worked on label Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment