Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CorsairLightingProtocol namespace and naming convention #191

Closed
wants to merge 4 commits into from
Closed

Use CorsairLightingProtocol namespace and naming convention #191

wants to merge 4 commits into from

Conversation

Legion2
Copy link
Owner

@Legion2 Legion2 commented Sep 27, 2020 •
edited
Loading

rename existing namespace
add namespace CorsairLightingProtocol close #168
rename some free functions

Todo:

  • add namespace CorsairLightingProtocol
  • rename some free functions
  • add using namespace CorsairLightingProtocol; to every sketch
  • create migration guide
  • update documentation

@Legion2 Legion2 added this to the 1.0.0 milestone Sep 27, 2020
@Legion2 Legion2 self-assigned this Sep 27, 2020
@Legion2 Legion2 mentioned this pull request Sep 27, 2020
Closed
4 tasks
@Legion2
added using directive in sketches
499646f 
this is for the user experience when using this namespaced library
@Legion2
added Command struct to namespace
044232d
@github-actions github-actions bot added the Stale label Jan 17, 2022
@github-actions github-actions bot closed this Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Legion2 Legion2

Labels
refactoring Stale
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Use CorsairLightingProtocol namespace and naming convention
1 participant
@Legion2