Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CorsairLightingProtocol namespace and naming convention #169

Closed
wants to merge 2 commits into from
Closed

Use CorsairLightingProtocol namespace and naming convention #169

wants to merge 2 commits into from

Conversation

Legion2
Copy link
Owner

@Legion2 Legion2 commented Aug 10, 2020 •
edited
Loading

rename existing namespace
add namespace CorsairLightingProtocol close #168
rename some free functions

Todo:

  • add namespace CorsairLightingProtocol
  • rename some free functions
  • add using namespace CorsairLightingProtocol; to every sketch
  • create migration guide

@Legion2 Legion2 added this to the 1.0.0 milestone Aug 10, 2020
@Legion2 Legion2 self-assigned this Aug 10, 2020
@stale
Copy link

stale bot commented Sep 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 19, 2020
@stale stale bot closed this Sep 26, 2020
@Legion2
Copy link
Owner Author

Legion2 commented Sep 27, 2020

reopened in #191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Legion2 Legion2

Labels
refactoring wontfix This will not be worked on
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Use CorsairLightingProtocol namespace and naming convention
1 participant
@Legion2