Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checklist stable release #101

Open
4 of 10 tasks
Legion2 opened this issue Jan 18, 2020 · 3 comments
Open
4 of 10 tasks

Checklist stable release #101

Legion2 opened this issue Jan 18, 2020 · 3 comments
Labels
enhancement New feature or request refactoring
Milestone
1.0.0

Comments

@Legion2
Copy link
Owner

Legion2 commented Jan 18, 2020 •
edited
Loading

Before the first stable release 1.0.0 there are some things that has to be addressed.

  • add the debug sketch to the github action ci
  • use the namespace CLP CorsairLightingProtocol for all classes and types Use CorsairLightingProtocol namespace and naming convention #168
  • move code from sketches (CommanderPRO...) to library src (the code is not reusable)
  • add some documentation about examples
  • use a more generic FastLED led chip type for all examples
  • add a CLP debug board for the debug sketch
  • generate a new default serial number (this would cause losing iCUE profiles for that arduino devices)
  • remove CorsairLightingNodePRO.h
  • update project descriptions, as now more corsair controller are supported
  • define goals and non-goals of this project
@Legion2 Legion2 added this to the 1.0.0 milestone Jan 18, 2020
@Legion2 Legion2 mentioned this issue Jan 20, 2020
Merged
Legion2 added a commit that referenced this issue Jan 20, 2020
@Legion2
added .clang-format
74ad67c 
added .editorconfig
formatted code with google clang format style and custom options #101
@Legion2 Legion2 mentioned this issue Jan 20, 2020
Merged
@stale
Copy link

stale bot commented Mar 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 26, 2020
@Legion2 Legion2 added the enhancement New feature or request label Mar 26, 2020
@stale stale bot removed the wontfix This will not be worked on label Mar 26, 2020
@Legion2 Legion2 removed the enhancement New feature or request label Mar 26, 2020
@Legion2
Copy link
Owner Author

Legion2 commented Mar 26, 2020

I have currently not much time to work on this. But I think the current implementation works very well and have no known bugs. So this refactoring can wait.

Legion2 added a commit that referenced this issue Mar 29, 2020
@Legion2
added debug sketch to ci #101
90cbadb
@Legion2 Legion2 mentioned this issue Apr 3, 2020
Merged
Legion2 added a commit that referenced this issue Apr 3, 2020
@Legion2
Arduino test compile Action (#119)
b97d130 
* use ArminJo/arduino-test-compile Action

* added debug sketch to ci #101

* updated examples-build-properties syntax

* use json string as input

* reduced number of jobs in workflow

* trigger workflow

* set version of arduino-test-compile action
@Legion2 Legion2 mentioned this issue Apr 15, 2020
Merged
@stale
Copy link

stale bot commented May 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added wontfix This will not be worked on and removed wontfix This will not be worked on labels May 13, 2020
@Legion2 Legion2 added the enhancement New feature or request label May 13, 2020
Legion2 added a commit that referenced this issue May 20, 2020
@Legion2
use WS2812B instead of NEOPIXEL in examples #101
383bd75
This was referenced May 20, 2020
Merged
Merged
@Legion2 Legion2 mentioned this issue Aug 10, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request refactoring
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@Legion2