Provide an option to store error responses in CLI #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make initial change to write error response as well when --include-all-responses flag is passed. - zytedata#38
Gallaecio
reviewed
Sep 8, 2023
Gallaecio
reviewed
Sep 8, 2023
|
In addition to those points, could you look into including a test for the change? |
- Improvement by PR suggestion - Add tests for the current changes. - zytedata#38
- Refactor the test using mocks - Add dependency - zytedata#38
- Remove RequestError import - zytedata#38
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
===========================================
+ Coverage 38.63% 53.88% +15.25%
===========================================
Files 10 10
Lines 365 373 +8
Branches 53 55 +2
===========================================
+ Hits 141 201 +60
+ Misses 223 167 -56
- Partials 1 5 +4
|
Gallaecio
reviewed
Jan 17, 2024
- address the comments in PR - zytedata#38
Gallaecio
reviewed
Jan 22, 2024
Gallaecio
reviewed
Jan 22, 2024
Comment on lines
+42
to
+46
| def write_output(content): | ||
| json.dump(content, out, ensure_ascii=False) | ||
| out.write("\n") | ||
| out.flush() | ||
| pbar.update() |
There was a problem hiding this comment.
TIL An inner function can depend on an outer scope variable as long as it is define before the inner function is called, rather than before the inner function is defined.
Gallaecio
reviewed
Jan 22, 2024
Gallaecio
reviewed
Jan 22, 2024
- address the comments in PR - zytedata#38
- change the domain to forbidden.example - zytedata#38
Gallaecio
reviewed
Jan 24, 2024
Gallaecio
approved these changes
Jan 24, 2024
- change the domain to forbidden.example - zytedata#38
wRAR
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make initial change to write error response as well when --store-errors flag is passed.
Resolves Provide an option to store error responses in CLI #38
Not taking care of errors belong to python 3.7 as its support will be removed soon.