Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Python 3.7 support #53

Merged
merged 1 commit into from
Feb 1, 2024
Merged

remove Python 3.7 support #53

merged 1 commit into from
Feb 1, 2024

Conversation

BurnzZ
Copy link
Contributor

@BurnzZ BurnzZ commented Oct 24, 2023

@kmike
Copy link
Collaborator

kmike commented Oct 24, 2023

It'd be good to keep it a bit longer, because this change would mean dropping Python 3.7 support in https://github.com/scrapy-plugins/scrapy-zyte-api. How big is the issue you're facing with CI?

@BurnzZ
Copy link
Contributor Author

BurnzZ commented Oct 24, 2023

How big is the issue you're facing with CI?

Not that big for 3.7 with regards to #52, which errors out since AsyncMock isn't available until 3.8 (ref). If the other versions are passing in the CI, then I think we're good.

@Gallaecio
Copy link
Contributor

#47 also aims to use AsyncMock. May we resume this?

@codecov-commenter
Copy link

Codecov Report

Merging #53 (d823668) into main (91b141e) will decrease coverage by 0.36%.
Report is 11 commits behind head on main.
The diff coverage is 25.00%.

❗ Current head d823668 differs from pull request most recent head c7b05ea. Consider uploading reports for the commit c7b05ea to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   43.28%   42.93%   -0.36%     
==========================================
  Files          10       10              
  Lines         365      368       +3     
  Branches       53       54       +1     
==========================================
  Hits          158      158              
- Misses        205      208       +3     
  Partials        2        2              
Files Coverage Δ
zyte_api/__version__.py 100.00% <100.00%> (ø)
zyte_api/aio/client.py 34.66% <ø> (ø)
zyte_api/aio/errors.py 56.25% <0.00%> (-12.99%) ⬇️

@BurnzZ
Copy link
Contributor Author

BurnzZ commented Jan 23, 2024

Hi @kmike , do you still want to keep Python 3.7 support for https://github.com/scrapy-plugins/scrapy-zyte-api ?

@kmike
Copy link
Collaborator

kmike commented Feb 1, 2024

I think we can drop 3.7 in both packages now.

@kmike kmike merged commit 35349d6 into main Feb 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants