Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove diff rendering from the assertion #8695

Open
wants to merge 1 commit into
base: series/2.x
Choose a base branch
from

Conversation

kaf-lamed-beyt
Copy link

Hi @jdegoes, I have managed to separate the diff rendering from the assertion, and I made sure that the SmartAseertions and AssertionVariants are using the Diff pattern.

But, I think I'm heading in the wrong direction here. I've imported the necessary diff render types in Assertion.scala and package.scala but the error below keeps showing when I run my tests.

[error]: Assertion.scala:725:43: could not find implicit value for parameter diffRender: zio.test.DiffRender[Int] [error]     hasIntersection(other)(hasSize(equalTo(1))).withCode("hasOneOf", valueArgument(other)) [error]                                           ^ 

[error] zio/test/shared/src/main/scala/zio/test/package.scala:387:39: could not find implicit value for parameter diffRender: zio.test.DiffRender[Boolean] [error]     assertImpl(true)(Assertion.equalTo(false)) ?? message

Kindly take a look when you see this. Thanks!

/claim #8664

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2024

CLA assistant check
All committers have signed the CLA.

@jdegoes
Copy link
Member

jdegoes commented Apr 5, 2024

@kaf-lamed-beyt The build is failing on all platforms. Can you take a look and ping me when everything is passing? Thank you!

@kaf-lamed-beyt
Copy link
Author

kaf-lamed-beyt commented Apr 5, 2024

will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants