-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zio-test: classic assertion equalTo
using Diff
#8664
Comments
/bounty $75 The rendering should happen outside, probably, so we can have a more modular architecture that permits code reuse and swapping in alternate renderings. |
💎 $75 bounty • ZIOSteps to solve:
Thank you for contributing to zio/zio! Add a bounty • Share on socials
|
Hi @jdegoes, I'd love to attempt this. Can you assign me? /attempt #8664
|
No need to assign, just follow the instructions of the @algora-pbc bot! |
Sounds good. |
@kaf-lamed-beyt: Reminder that in 7 days the bounty will become up for grabs, so please submit a pull request before then 🙏 |
@varshith257: We appreciate your enthusiasm but since you already have 3 active bounty attempts, we're going to keep this open for other contributors to attempt. 🫡 |
/attempt #8664 |
@varshith257: We appreciate your enthusiasm but since you already have 3 active bounty attempts, we're going to keep this open for other contributors to attempt. 🫡 |
/attempt #8664 Options |
Note The user @kaf-lamed-beyt is already attempting to complete issue #8664 and claim the bounty. We recommend checking in on @kaf-lamed-beyt's progress, and potentially collaborating, before starting a new solution. |
@jdegoes As per #8808 (comment), I think we can't unify the same rendering logic for both classic and smart Assertions.
For this in SmartAssertions.scala the Diff rendering can be done outside, but we can't unify the same DIff logic to classic Assertions. Will open a PR with these confined changes of the rendering of Smart Assertions Diff method happens outside and can be re-used. OR Better if we can move both rendering codes of classic and smart assertions to a separate file and can be done outside of it and can be reused. |
At the moment the equalTo of smart assertions uses the
Diff
mechanism, however the classic assertion does notAlso, the rendering of the
Diff
seems to happen in the assertion, is that something we would like ?The text was updated successfully, but these errors were encountered: