Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Mimetype application/x-zip-compressed interpreted as a text field #3203

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

varshith257
Copy link
Contributor

@varshith257 varshith257 commented Nov 9, 2024

/claim #3200
Fixes #3200

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.14%. Comparing base (f164c90) to head (db4d439).
Report is 31 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3203      +/-   ##
==========================================
- Coverage   65.09%   61.14%   -3.96%     
==========================================
  Files         161      161              
  Lines       10551    11390     +839     
  Branches     2024     1970      -54     
==========================================
+ Hits         6868     6964      +96     
- Misses       3683     4426     +743     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@varshith257
Copy link
Contributor Author

@Dennis4b
Copy link
Contributor

Dennis4b commented Nov 9, 2024

Not sure if it is my place to comment, but application/json and application/xml should never make it to parseCustomMediaType so that check would be superfluous.

Second I am not sure what unsafeParseCustomMediaType is intended for, but should it not have the same fix?

@varshith257
Copy link
Contributor Author

Thanks @Dennis4b. Yes, I think for both methods we need the same and updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mimetype application/x-zip-compressed interpreted as a text field
3 participants