Mimetype application/x-zip-compressed interpreted as a text field

[Dennis4b]

I am running into an issue where parsed form fields (using .body.asMultipartFormStream) are recognized/decoded as FormField.Text, when Windows browsers (seen with Chrome and Edge) attach files with mimetype application/x-zip-compressed instead of application/zip. This means the binary file data is coerced into a string and mangled and unusable.

The Mediatypes are generated from jshttp which does not include this mimetype, which would be one thing that could address this issue, but there seems to be the intention to fall back to application/octet-stream which however is not happening, instead falling back to a non-binary Text type thereby mangling the data irreversibly.

Specifically in FormField.scala:

      contentType      = extract._2
        .flatMap(x => MediaType.forContentType(x.value))
        .getOrElse(MediaType.application.`octet-stream`)

however in MediaType.forContentType(...):

contentTypeMap.get(contentTypeLC).orElse(parseCustomMediaType(contentTypeLC))

which does:

def parseCustomMediaType(customMediaType: String): Option[MediaType] = {
    val contentTypeParts = customMediaType.split('/')
    if (contentTypeParts.length == 2) {
      val subtypeParts = contentTypeParts(1).split(';')
      if (subtypeParts.length >= 1) {
        Some(
          MediaType(
            mainType = contentTypeParts.head,
            subType = subtypeParts.head,
            parameters = if (subtypeParts.length >= 2) parseOptionalParameters(subtypeParts.tail) else Map.empty,
          ),
        )
      } else None
    } else None
  }

which is going to return a MediaType with binary set to false and not fall back to application/octet-stream.

I do prefer preserving the mimetype the browser set as opposed to setting it to application/octet-stream, since I can deal with that in my app, but the data should IMHO be treated as binary unless certain it really is text.

That would mean that parseCustomMediaType would always explicitly set binary=true if the mimetype does not start with text/ (and possibly other mimetype families known to be text)

[jdegoes]

/bounty $75

[algora-pbc]

💎 $75 bounty • ZIO

Steps to solve:

1. Start working: Comment /attempt #3200 with your implementation plan
2. Submit work: Create a pull request including /claim #3200 in the PR body to claim the bounty
3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to zio/zio-http!

Add a bounty • Share on socials

Attempt	Started (GMT+0)	Solution
🟢 @varshith257		#3203

[algora-pbc]

💡 @varshith257 submitted a pull request that claims the bounty. You can visit your bounty board to reward.