-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move git status out of Entry #22224
Move git status out of Entry #22224
Conversation
the git panel co-authored-by: Mikayla <[email protected]>
mark places that used to use it for refactoring co-authored-by: Cole <[email protected]>
co-authored-by: Cole <[email protected]>
Co-authored-by: Mikayla <[email protected]> Co-authored-by: Nathan <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Mikayla <[email protected]>
…tories co-authored-by: Cole <[email protected]>
bf8b83c
to
51c3016
Compare
co-authored-by: Cole <[email protected]>
co-authored-by: cole <[email protected]>
Co-authored-by: Mikayla <[email protected]>
to the local and repository entries, and enhance the RepositoryWorkDirectory type to make the worktree code more ergonomic.
APIs feel good, concept feels good.... now we just need to make it work.
Co-authored-by: Mikayla <[email protected]>
Co-authored-by: Mikayla <[email protected]>
Co-authored-by: Mikayla <[email protected]>
Co-authored-by: Mikayla <[email protected]>
Co-authored-by: Mikayla <[email protected]>
Co-authored-by: Mikayla <[email protected]>
Co-authored-by: Mikayla <[email protected]>
1bd2696
to
f6e79b5
Compare
Co-authored-by: Mikayla <[email protected]>
Co-authored-by: Mikayla <[email protected]>
Co-authored-by: Mikayla <[email protected]>
Should we take 8c352ef out of this PR since it isn't related (and adds a lot of additional surface area being touched)? Seems like it could easily be a separate PR. |
@maxdeviant no, when we ran the typos CLI locally to fix typo failures on this branch, this is what it gave us. |
* Follows-up #22224 , by adjusting `impl PartialEq for OutlineEntryOutline` to compare outline items' values too. Before that, all outline items from the same excerpt were considered equal. Adds a test for this * Stops re-revealing items in the outline panel, when it's focused: now, when someone scrolls over outline panel items, there is no extra work happening: the "revealed" item is the one scrolled to Release Notes: - Fixed outline items not scrolling properly
Hi, I am sorry to have to report this only now, after some serious git bisect I found that this PR merge is the one that broke my git support for repos in sub-folders
Can you fix it ? |
Hi @williamdes, thanks for the report. Could you point me to a specific repo where the git blame is not showing up for you after this change? I've tried to reproduce the issue with some simple test projects and inline git blame seems to work fine in at least the following situations:
|
Hi @cole-miller
Every repository is affected. I do the following pattern to sort my repos:
If I open Stupid possibility, could it be the folder name ? |
test_propagate_statuses_for_repos_under_project
WorkDirectoryEntry
withWorkDirectory
inRepositoryEntry
worktree_repository_statuses
table, adjust as needed)Release Notes: