Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix outline items navigation #22890

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Fix outline items navigation #22890

merged 2 commits into from
Jan 9, 2025

Conversation

SomeoneToIgnore
Copy link
Contributor

  • Follows-up Move git status out of Entry #22224 , by adjusting impl PartialEq for OutlineEntryOutline to compare outline items' values too.
    Before that, all outline items from the same excerpt were considered equal.

Adds a test for this

  • Stops re-revealing items in the outline panel, when it's focused: now, when someone scrolls over outline panel items, there is no extra work happening: the "revealed" item is the one scrolled to

Release Notes:

  • Fixed outline items not scrolling properly

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 9, 2025
@SomeoneToIgnore SomeoneToIgnore added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit a0284a2 Jan 9, 2025
13 checks passed
@SomeoneToIgnore SomeoneToIgnore deleted the kb/outline-comparison branch January 9, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SomeoneToIgnore