Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from Shopify:main #2

Open
wants to merge 199 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
199 commits
Select commit Hold shift + click to select a range
e254d82
feat(🌠): Image.makeImageTexture() (#2417)
wcandillon May 8, 2024
bc8da74
Revert "feat(🌠): Image.makeImageTexture() (#2417)" (#2422)
wcandillon May 10, 2024
7361ec8
chore(deps): bump the bundler group across 1 directory with 2 updates…
dependabot[bot] May 21, 2024
ea1ba40
feat(📸): video support (#2438)
wcandillon May 22, 2024
71e3899
:green_heart:
wcandillon May 22, 2024
83e793f
fix(📹): fix video framerate (#2446)
wcandillon May 28, 2024
7284ec6
fix(📼): add seek playback option (#2448)
wcandillon May 28, 2024
fc55cb4
Update SVG Image support (#2450)
wcandillon May 28, 2024
9436209
fix(📹): useVideo fixes (#2451)
wcandillon May 30, 2024
8bd1ffb
Document accessibility support (#2460)
wcandillon Jun 4, 2024
bcab375
fix(📹): Better support for rotated videos (#2461)
wcandillon Jun 6, 2024
04ddb02
fix(📸): Add audio support for videos (#2462)
wcandillon Jun 6, 2024
df5162e
fix(📚): Improve documentation on useVideo (#2463)
wcandillon Jun 6, 2024
6cc96d2
fix deadlink (#2468)
wcandillon Jun 10, 2024
798eb83
Deprecate onTouch (#2470)
wcandillon Jun 11, 2024
badb5a4
Fix regression in examples on web (#2471)
wcandillon Jun 11, 2024
1443332
chore(deps): bump the npm_and_yarn group across 4 directories with 1 …
dependabot[bot] Jun 12, 2024
7d391ae
fix(📸): load video metadata on dedicated thread (#2473)
wcandillon Jun 12, 2024
524072c
fix(🤖): remove unnecessary video frame copies on Android (#2476)
wcandillon Jun 12, 2024
81654ce
fix(📹): Video support on Web (#2477)
wcandillon Jun 13, 2024
391fb9a
Add a magnifying glass example (#2419)
rayronvictor Jun 13, 2024
cf226be
fix(🐎): Fix regression with Reanimated (#2482)
wcandillon Jun 14, 2024
6a8e64e
Revert "Add a magnifying glass example (#2419)" (#2483)
wcandillon Jun 14, 2024
76ee745
fix(🧵): thread safety in RNSkJsiViewApi.h (#2481)
wcandillon Jun 14, 2024
3be25d2
fix(🐎): Fix reanimated regression
wcandillon Jun 14, 2024
d222222
:green_heart:
wcandillon Jun 14, 2024
8e0a82c
chore(deps-dev): bump ws (#2488)
dependabot[bot] Jun 27, 2024
a3a1508
Update web documentatioin to explain gotcha (#2486)
makeable Jun 27, 2024
b657c9f
🔥 remove bogus use of -j in ninja (#2504)
wcandillon Jun 28, 2024
fafff4c
fix(🐛): fix concurrency issue with surface events (#2505)
wcandillon Jun 28, 2024
279afb9
fix(🐯): SVG support on Web (#2506)
wcandillon Jun 28, 2024
34fa5c5
remove unused enum (#2508)
wcandillon Jun 28, 2024
cda67f3
fix(🐛): fix black screen when pausing on Android (#2510)
wcandillon Jun 28, 2024
5665baa
fix(🐛): Fix parameter handling in SkTypefaceFontProvider.matchFamilyS…
wcandillon Jul 5, 2024
cc7f30d
Refactor example to use Canvas as children of GestureDector (#2520)
wcandillon Jul 8, 2024
3ad2171
chore(deps): bump the npm_and_yarn group across 3 directories with 2 …
dependabot[bot] Jul 25, 2024
edcf144
fixes #2529 (#2543)
wcandillon Jul 25, 2024
76343ce
fix(🤖): imprecision in seek() (#2532)
mrEuler Jul 25, 2024
45ae9cb
fix(🍏): "Timed out waiting for modules to be invalidated" error after…
wcandillon Jul 25, 2024
3c37319
chore(deps): bump the npm_and_yarn group across 4 directories with 1 …
dependabot[bot] Jul 31, 2024
56a3894
Fix typo in paragraph component documentation (#2552)
objectiveSee Jul 31, 2024
aadd424
fix(🌉): remove currentBridge (#2548)
WoLewicki Aug 1, 2024
30c1284
💚 fix CI (#2564)
wcandillon Aug 6, 2024
682b32a
fix(🏞️): add getFrameCount to animated images (#2568)
terrysahaidak Aug 7, 2024
b9a38f0
Fix typo TrianglesStrip -> TriangleStrip (#2566)
mrEuler Aug 22, 2024
9de8da3
fix: add missing dispose and typename to skparagraph (#2570)
terrysahaidak Aug 22, 2024
8e4bc1e
fix(🤖): Fix Android build on 0.75 (#2586)
wcandillon Aug 22, 2024
ff13fa5
🔥 Remove Flipper dependency (#2592)
wcandillon Aug 26, 2024
568b3a7
chore(deps): bump rexml in /example in the bundler group (#2588)
dependabot[bot] Aug 26, 2024
fcbcf28
chore(deps): bump the npm_and_yarn group across 4 directories with 1 …
dependabot[bot] Aug 26, 2024
00ea5da
💚 fix Android build regression (#2595)
wcandillon Aug 27, 2024
a811666
Make root package private (#2594)
wcandillon Aug 28, 2024
09e6652
💚 artefact upload in build-skia (#2598)
wcandillon Aug 29, 2024
d597161
chore(deps): bump the npm_and_yarn group across 2 directories with 1 …
dependabot[bot] Aug 29, 2024
151e080
💚 fix build step (#2599)
wcandillon Aug 29, 2024
c4e99e3
Migrate to a monorepo (#2603)
wcandillon Sep 3, 2024
a53ed23
fix(🍏): bundler dep for 2020-36327 (#2606)
wcandillon Sep 4, 2024
5a683bf
Migrate to turborepo (#2608)
wcandillon Sep 5, 2024
9e8c3f5
Refine CI tasks (#2611)
wcandillon Sep 5, 2024
ec99607
alter monorepo the name, to avoid conflict with the package (#2615)
Simek Sep 6, 2024
5938d7b
Refine e2e CI task (#2612)
wcandillon Sep 6, 2024
d51beb3
fix(🐛): improve Canvas unmounting (#2619)
wcandillon Sep 10, 2024
8b4581c
fix bug in documentation building (#2620)
wcandillon Sep 10, 2024
d243c1f
Fix release for monorepo (#2621)
wcandillon Sep 10, 2024
84e02f8
Fix release for monorepo support (#2622)
wcandillon Sep 10, 2024
9cba5ea
Update release step (#2623)
wcandillon Sep 10, 2024
baa6b54
:green_heart: (#2624)
wcandillon Sep 10, 2024
d36f2f9
💚 (#2625)
wcandillon Sep 10, 2024
8816991
Improve APK caching in CI (#2626)
wcandillon Sep 10, 2024
25b1fb3
fix(🐛): yarn pack regression (#2629)
wcandillon Sep 11, 2024
963d1c3
chore(deps): bump the npm_and_yarn group across 1 directory with 3 up…
dependabot[bot] Sep 11, 2024
746d8b5
💚 Fix CI (#2641)
wcandillon Sep 25, 2024
0204413
Remove turborepo cache on Android (#2643)
wcandillon Sep 25, 2024
1f27aa6
💚 fix build Skia action (#2644)
wcandillon Sep 26, 2024
8b04f4f
💚 (#2645)
wcandillon Sep 26, 2024
32cd6cf
💚 fix build-skia script (#2646)
wcandillon Sep 26, 2024
950bca7
fix(⬆️): Upgrade to Skia m130 (#2648)
wcandillon Sep 27, 2024
a732d3b
build skia on large instance (#2649)
wcandillon Sep 27, 2024
70d05a7
💚 fix CI (#2651)
wcandillon Sep 27, 2024
18147ad
💚 fix build-skia step (#2652)
wcandillon Sep 27, 2024
a7970cf
💚 fix build-skia step (#2654)
wcandillon Sep 27, 2024
5c58cae
feat(🔺): experimental WebGPU Canvas integration (#2632)
wcandillon Sep 29, 2024
1d6614a
✍️ minor edit in the building steps (#2653)
wcandillon Sep 29, 2024
bb22157
fix: use TextDecorationStyle for SkTextStyle.decorationStyle (#2628)
fand Sep 30, 2024
8f016e9
💚 (#2659)
wcandillon Sep 30, 2024
4c8fd33
fix(🌎): componentProps prop to WithSkiaWeb (#2662)
santitopo Sep 30, 2024
4e239fd
fix(💚): Remove duplicate headers on iOS (#2665)
wcandillon Sep 30, 2024
bf416d8
fix(🤖): typo in directive (#2668)
wcandillon Oct 1, 2024
f4db230
fix(💚): add missing xcframeworks files and remove duplicated headers …
wcandillon Oct 1, 2024
fe24c03
Disable turborepo cache (#2673)
wcandillon Oct 1, 2024
d2b5e8b
feat(🔥): Remove deprecated onTouch prop (#2669)
wcandillon Oct 1, 2024
ddfa6eb
Remove unused object (#2676)
wcandillon Oct 3, 2024
569d071
fix(⬆️): Upgraded Android build to support RN 0.76 (#2694)
chrfalch Oct 17, 2024
712405d
💚 disable turbo cache (#2710)
wcandillon Oct 28, 2024
5095c44
fix(🍏): support for ProMotion 120hz (#2690)
SamuelScheit Oct 28, 2024
b591714
chore(deps): bump http-proxy-middleware (#2712)
dependabot[bot] Oct 28, 2024
25476d4
Remove --cache-dir option in turbomodules (#2713)
wcandillon Oct 29, 2024
9309027
Refactor Skia build scripts
wcandillon Oct 29, 2024
4a2d7af
🧹 Refactor Skia build scripts
wcandillon Oct 29, 2024
4bd0d9e
Update installation requirements
wcandillon Nov 1, 2024
950279b
Merge pull request #2720 from Shopify/wcandillon-patch-35
wcandillon Nov 1, 2024
7438a37
fixes #2715
wcandillon Nov 1, 2024
04b8ad8
Merge pull request #2721 from Shopify/with-skia-web
wcandillon Nov 1, 2024
b7b02e7
Update bug_report.yml
wcandillon Nov 1, 2024
5c38b27
Merge pull request #2722 from Shopify/wcandillon-patch-36
wcandillon Nov 1, 2024
a3d22e2
Update WebGPU demo
wcandillon Nov 2, 2024
ce475ac
Merge pull request #2723 from Shopify/wgpu
wcandillon Nov 2, 2024
569acc9
fix(🤖): fix minor threading issue on Android (#2725)
wcandillon Nov 5, 2024
d10a413
fix(💚): fix regression with pixel density on iOS (#2726)
wcandillon Nov 5, 2024
7eb2dac
Add test for Box component (#2728)
wcandillon Nov 7, 2024
4c8d18b
⬆️ Fix bogus requirements (#2735)
wcandillon Nov 14, 2024
5c0f38f
fix(🪨): enable experiment Graphite via build flag (#2736)
wcandillon Nov 14, 2024
63132c4
Update Skia submodule to chrome/m132 (#2738)
wcandillon Nov 15, 2024
181c48a
🪨 Video support in Graphite (#2739)
wcandillon Nov 16, 2024
ef5d52e
🪨 Update instructions about Graphite (#2740)
wcandillon Nov 16, 2024
53a8db5
fix(🍏): Fix performance regression on iOS (#2744)
wcandillon Nov 18, 2024
6fbaeab
fix(🤖): Fix serious Android threading issue (#2749)
wcandillon Nov 19, 2024
f298622
💄 minor code refactoring (#2750)
wcandillon Nov 20, 2024
ad6e7d0
fix(💚): Fix iOS segfault error for surfaces with 0 size (#2753)
wcandillon Nov 20, 2024
516bdb5
💄 minor refactoring (#2752)
wcandillon Nov 20, 2024
d314745
fix(🤖): bug fixes in OpenGL renderer (#2759)
wcandillon Nov 21, 2024
f4db5f5
fix(🖼️): fix thread safety in SkImage and viewRef.makeImageSnapshot (…
wcandillon Nov 22, 2024
1352eca
🏞️ offscreen example (#2765)
wcandillon Nov 23, 2024
ba1db84
fix(🤖): Remove internal draw loop (#2763)
wcandillon Nov 23, 2024
412d3a3
fix(🐛): Fix dangling pointer in requestRedraw (#2768)
wcandillon Nov 24, 2024
aab5771
fix(🐛): fix build regression on fabric (#2769)
wcandillon Nov 24, 2024
b6a848f
chore(deps): bump cross-spawn from 7.0.3 to 7.0.6 (#2770)
dependabot[bot] Nov 24, 2024
75c073c
:fire: (#2778)
wcandillon Nov 29, 2024
06ecae8
fix(🖍️): fix regression in ColorType enum (#2779)
wcandillon Nov 29, 2024
88dec7f
feat(👨🏻‍🎨): Opaque property (#2776)
wcandillon Nov 29, 2024
3401111
fix(🤖): fix bug with default clear color on Android offscreen surface…
wcandillon Nov 30, 2024
0d16463
chore(🔥): remove JsiValueWrapper (#2783)
wcandillon Dec 2, 2024
4673f8a
⬆️ upgrade deprecated gh action (#2787)
wcandillon Dec 3, 2024
32fbd1c
chore(🔥): remove unused code (#2785)
wcandillon Dec 3, 2024
0e305d0
Update debugging guidance in docs (#2788)
huntie Dec 4, 2024
31cd2f6
chore: gitignore lib folders (#2742)
Saadnajmi Dec 4, 2024
42f81f0
feat(🧮): Add invert on Matrix4 (#2791)
wcandillon Dec 4, 2024
680a762
chore(🍏): Refactor Metal backend (#2790)
wcandillon Dec 6, 2024
de87571
fix(🍏): fix reparenting of View on iOS (#2793)
wcandillon Dec 6, 2024
7211460
chore(🍏): remove unused code (#2766)
wcandillon Dec 6, 2024
f9c8119
feat(🏞️): cross context texture sharing and external texture import (…
fdecampredon Dec 6, 2024
cc15a30
chore(🧪): don't search lib built files for tests (#2794)
wcandillon Dec 6, 2024
52f2e44
chore(🖼️): minor refactoring in platform context (#2795)
wcandillon Dec 7, 2024
4073bb4
chore(👷): remove unused namespace (#2797)
wcandillon Dec 8, 2024
21eb223
chore(⚠️): Fix some clang warnings (#2798)
wcandillon Dec 9, 2024
2cfa890
fix(🍏): use dedicated bridge (#2760)
alexandrius Dec 9, 2024
e9bb166
fix(🤖): fix vulkan/angle support (#2801)
wcandillon Dec 11, 2024
487df16
chore(:arrow_up:): Upgrade Reanimated version (#2802)
wcandillon Dec 13, 2024
07ec2ad
chore(deps): bump nanoid from 3.3.7 to 3.3.8 (#2805)
dependabot[bot] Dec 14, 2024
1908603
fix(🤖): fix build on Android (#2806)
wcandillon Dec 14, 2024
9ce6660
fix(🤖): Regression with java exceptions on Android (#2808)
wcandillon Dec 15, 2024
88980ba
fix(🎨): fix bug in drawAtlas() (#2809)
wcandillon Dec 16, 2024
7511466
fix(🌎): Add makeImageSnapshotAsync() on Web (#2810)
wcandillon Dec 16, 2024
bd526a5
fix(🐯): fix minor parameter bug in drawSvg() (#2811)
wcandillon Dec 16, 2024
b72c441
fix(⏺️): fix memory error with rounded rectangles (#2812)
wcandillon Dec 16, 2024
84a3b3a
fix(🤖): Fix regression with PictureView on Android (#2813)
wcandillon Dec 16, 2024
e77754c
fix(🖼️): fix minor bug with LinearGammaColorFilter node factory (#2820)
wcandillon Dec 18, 2024
39f08a0
chore(📚): remove manual context injection example (#2815)
wcandillon Dec 18, 2024
cca99c4
fix(🎨): fix race condition in SkiaDomView (#2823)
wcandillon Dec 18, 2024
b7a55c5
fix(⏺️): fix bug in isRRect (#2822)
wcandillon Dec 18, 2024
bce4183
fix(📝): fix bug with textAlign property in paragraph style (#2821)
wcandillon Dec 18, 2024
dfc710f
update dan's react native lab tutorials (#2828)
friyiajr Dec 22, 2024
7420bee
docs: add video tutorials (#2827)
enzomanuelmangano Dec 22, 2024
5920b5d
fix typo (#2830)
wcandillon Dec 22, 2024
65024d2
remove bogus log messages (#2832)
wcandillon Dec 23, 2024
79795de
docs: remove duplicated words in textures documentation (#2833)
koliao Dec 29, 2024
9d59c74
fix(🤖): fix resizing on Android (#2840)
wcandillon Dec 29, 2024
c462945
chore(🖼️): use int for canvas size (#2841)
wcandillon Dec 29, 2024
ccf403c
fix(🚤): fix bug on first frame (#2842)
wcandillon Dec 29, 2024
d646276
chore(🔥): remove unused tests (#2843)
wcandillon Dec 29, 2024
1aeb7e2
chore(🧪): improve type parsing/serialization in e2e testing (#2844)
wcandillon Dec 29, 2024
4b821d3
chore(🍏): add macOS to build matrix (#2835)
Saadnajmi Dec 29, 2024
64f88d5
chore(🍏): fix typo (#2846)
wcandillon Dec 30, 2024
1e2ef33
chore(🍏): fix ci (#2848)
wcandillon Dec 30, 2024
a3b8c83
chore(🐎): worketlize util functions (#2845)
wcandillon Dec 30, 2024
34acce8
chore(📖): mention that transformations are in radians (#2850)
wcandillon Dec 30, 2024
051ada0
chore(⬆️): upgrade reconciler types (#2851)
wcandillon Dec 30, 2024
f11e2e4
chore(💚): remove unecessary flags (#2847)
wcandillon Dec 30, 2024
8048ef2
chore(🧪): enable new scene graph on the test suite (#2839)
wcandillon Dec 30, 2024
defff6c
fix(🐎): minor improvement to the reanimated package detection (#2853)
wcandillon Dec 30, 2024
43a63af
chore(🌎): add RN Web example (#2852)
wcandillon Dec 30, 2024
393dd76
feat(🌎): Enable new reconciler on RN Web (#2854)
wcandillon Dec 30, 2024
899913d
chore(💄): Minor scenegraph refactoring (#2855)
wcandillon Dec 31, 2024
592f06c
chore(💄): Minor refactoring in common drawing props (#2860)
wcandillon Jan 4, 2025
167e4e2
fix(🐎): remove reanimated 2 support (#2864)
wcandillon Jan 6, 2025
fef5aba
fix(🖼️): improved scene graph model (RN Web only for now) (#2863)
wcandillon Jan 6, 2025
a78b255
fix(🐛): Fix serious memory error with data loading hooks (useImage, u…
wcandillon Jan 7, 2025
16abb40
feat(🍏): add tvOS support (#2857)
RuudBurger Jan 9, 2025
eee2fb0
chore(🐙): switch to large instance to build Skia (#2870)
wcandillon Jan 9, 2025
726f05c
chore(📚): Add mention of the tvOS support (#2872)
wcandillon Jan 9, 2025
4214bc1
chore(📚): Mention TV support on installation page (#2873)
RuudBurger Jan 9, 2025
1dc29eb
chore(📚): minor change (#2874)
wcandillon Jan 9, 2025
d1debdd
chore(🐙): fix typo in issue template (#2876)
wcandillon Jan 9, 2025
c5f48cc
fix(🐎): minor improvements to the new reconciler (#2871)
wcandillon Jan 9, 2025
74b85eb
chore(🐙): run e2e tests on actual GPU (#2877)
wcandillon Jan 10, 2025
f45d88f
chore(🐙): minor task renaming (#2879)
wcandillon Jan 10, 2025
d54e29b
chore(💄): cpp code formatting (#2881)
wcandillon Jan 10, 2025
8b14242
feat(🏞️): fix default image sampling and add full control of sampling…
wcandillon Jan 10, 2025
5c1f6dc
chore(🐎): add support for nested display lists in the reconciller (#2…
wcandillon Jan 10, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
40 changes: 31 additions & 9 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,34 +6,56 @@ body:
attributes:
value: |
Please provide all the information requested. Issues that do not follow this format are likely to stall.

- type: textarea
id: description
attributes:
label: Description
description: Briefly describe the issue and the expected versus actual behavior.
validations:
required: true

- type: input
id: version
id: skia_version
attributes:
label: Version
description: What react-native-skia version does this appear on?
label: React Native Skia Version
description: Specify the version of react-native-skia where the issue occurs.
validations:
required: true

- type: input
id: react_native_version
attributes:
label: React Native Version
description: Specify the version of React Native used.
validations:
required: true

- type: checkboxes
id: new_architecture
attributes:
label: Using New Architecture
description: Check this box if the new architecture is enabled.
options:
- label: Enabled
required: false

- type: textarea
id: reproduction
attributes:
label: Steps to reproduce
label: Steps to Reproduce
description: Provide a detailed list of steps that reproduce the issue.
validations:
required: true

- type: textarea
id: extra
attributes:
label: Snack, code example, screenshot, or link to a repository
label: Snack, Code Example, Screenshot, or Link to Repository
description: |
Please provide a Snack (https://snack.expo.io/), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem.
Please provide a Snack (https://snack.expo.io/), a link to a repository on GitHub, or a minimal code example that reproduces the problem.
You may provide a screenshot of the application if you think it is relevant to your bug report.
Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve
Please note that a reproducer is mandatory. Issues without reproducer are more likely to stall and will be closed.
Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve.
A reproducer is mandatory. Issues without reproducers are more likely to stall and may be closed.
validations:
required: true
required: true
57 changes: 57 additions & 0 deletions .github/actions/setup/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
name: Setup
description: Setup Node.js and install dependencies

inputs:
github_token:
description: 'GitHub Token'
required: false
download_skia:
description: 'Download Skia Binary Artifacts'
required: false
default: 'true'

runs:
using: composite
steps:
- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version-file: .nvmrc

- name: Cache dependencies
id: yarn-cache
uses: actions/cache@v3
with:
path: |
**/node_modules
.yarn/install-state.gz
key: ${{ runner.os }}-yarn-${{ hashFiles('yarn.lock') }}-${{ hashFiles('**/package.json', '!node_modules/**') }}
restore-keys: |
${{ runner.os }}-yarn-${{ hashFiles('yarn.lock') }}
${{ runner.os }}-yarn-

- name: Install dependencies
if: steps.yarn-cache.outputs.cache-hit != 'true'
run: yarn install --immutable
shell: bash

- name: Download Skia Binary Artifacts
if: ${{ inputs.download_skia == 'true' }}
uses: dawidd6/action-download-artifact@v2
with:
workflow: "build-skia.yml"
repo: shopify/react-native-skia
path: packages/skia/artifacts
branch: main

- name: Copy Artifacts to libs folder
if: ${{ inputs.download_skia == 'true' }}
working-directory: packages/skia
run: yarn workflow-copy-libs
shell: bash

- name: Copy Skia Headers
if: ${{ inputs.download_skia == 'true' }}
working-directory: packages/skia
run: yarn copy-skia-headers
shell: bash
102 changes: 0 additions & 102 deletions .github/workflows/android-ubuntu.yml

This file was deleted.

Loading
Loading