forked from Shopify/react-native-skia
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from Shopify:main #2
Open
pull
wants to merge
197
commits into
yixuqiu:main
Choose a base branch
from
Shopify:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#2428) Bumps the bundler group with 2 updates in the /example directory: [activesupport](https://github.com/rails/rails) and [rexml](https://github.com/ruby/rexml). Updates `activesupport` from 6.1.7.3 to 6.1.7.7 - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v7.1.3.3/activesupport/CHANGELOG.md) - [Commits](rails/rails@v6.1.7.3...v6.1.7.7) Updates `rexml` from 3.2.5 to 3.2.8 - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.2.5...v3.2.8) --- updated-dependencies: - dependency-name: activesupport dependency-type: indirect dependency-group: bundler - dependency-name: rexml dependency-type: indirect dependency-group: bundler ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…update (#2472) Bumps the npm_and_yarn group with 1 update in the /docs directory: [braces](https://github.com/micromatch/braces). Bumps the npm_and_yarn group with 1 update in the /example directory: [braces](https://github.com/micromatch/braces). Bumps the npm_and_yarn group with 1 update in the /fabricexample directory: [braces](https://github.com/micromatch/braces). Bumps the npm_and_yarn group with 1 update in the /package directory: [braces](https://github.com/micromatch/braces). Updates `braces` from 3.0.2 to 3.0.3 - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) Updates `braces` from 3.0.2 to 3.0.3 - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) Updates `braces` from 3.0.2 to 3.0.3 - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) Updates `braces` from 3.0.2 to 3.0.3 - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: braces dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: braces dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: braces dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add a magnifying glass example * lint fix --------- Co-authored-by: William Candillon <[email protected]>
Bumps the npm_and_yarn group with 1 update in the /package directory: [ws](https://github.com/websockets/ws). Updates `ws` from 8.11.0 to 8.17.1 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.11.0...8.17.1) --- updated-dependencies: - dependency-name: ws dependency-type: direct:development dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Update the web documentation to explain a gotcha when loading components that are within the router folder. Also update the example so it is using a location that hints towards a different folder. Co-authored-by: William Candillon <[email protected]>
Because the view is created after a drawing (SkPicture for instance), setting the picture would fail because no view info would be existing for that picture. Hence the drawing would go to wast
--------- Co-authored-by: William Candillon <[email protected]>
this upgrade is needed to get the correct types for the fiber reconciler.
this is a minor improvement to the package detection where a webpack config may not throw an exception for `require('react-native-reanimated')` but rather return an empty object instead.
This would be a breaking change but we realized that the reanimated 2 support was actually not working in recent versions
This is a new model where use a Picture recorder that supports animation values. Consider the following deeply nested tree: ```jsx <Image x={0} y={0} width={width} height={height} image={oslo} fit="cover"> <ColorMatrix matrix={matrix} /> <LinearToSRGBGamma> <Lerp t={t}> <ColorMatrix matrix={purple} /> <ColorMatrix matrix={blackAndWhite} /> </Lerp> </LinearToSRGBGamma> </Image> ``` This will generate the following instruction set: ``` [ { type: 'SaveCTM', props: { transform: [Array] } }, { type: 'SavePaint', props: {} }, { type: 'PushColorFilter', colorFilterType: 'skMatrixColorFilter', props: { matrix: [Array] } }, { type: 'PushColorFilter', colorFilterType: 'skMatrixColorFilter', props: { matrix: [Array] } }, { type: 'PushColorFilter', colorFilterType: 'skMatrixColorFilter', props: { matrix: [Array] } }, { type: 'PushColorFilter', colorFilterType: 'skLerpColorFilter', props: { t: 0.5 } }, { type: 'PushColorFilter', colorFilterType: 'skLinearToSRGBGammaColorFilter', props: {} }, { type: 'ComposeColorFilter' }, { type: 'MaterializePaint' }, { type: 'DrawImage', props: { x: 0, y: 0, width: 256, height: 256, image: [JsiSkImage], fit: 'cover' } }, { type: 'RestorePaint' }, { type: 'RestoreCTM' } ] ```
…seFont) (#2866) Hooks like useImage wrong manually dispose the data when unmounting even thought the reference might be still used somewhere else. In the case of the Skia reconciler, the image is disposed even before any kind of unmounting is signaled to the reconciler.
The number of prebuilt binaries Skia ships is getting increasingly bigger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )