Add support for "[uint, uint]" as label #392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shane-XB-Qian
suggested changes
Sep 14, 2023
andlrc
force-pushed
the
sig-params-label-uint-uint
branch
from
c79ddce to
69ad3d3
Compare
yegappan
reviewed
Sep 14, 2023
autoload/lsp/signature.vim
Outdated
| hllen = label->len() | ||
| startcol = text->stridx(label) | ||
| else | ||
| startcol = label[0] |
There was a problem hiding this comment.
According to the spec:
The offsets are based on a UTF-16 string representation as Position and Range does.
So this needs a conversion to a UTF-8 offset.
There was a problem hiding this comment.
Good point. I'll not have time until next week to look at this. I also think it's worth investigating if ClientCapabilities.general.positionEncodings should be taken into account.
andlrc
force-pushed
the
sig-params-label-uint-uint
branch
from
69ad3d3 to
0b9bba0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #391